Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Experimentation Service client #1934

Merged
merged 47 commits into from
May 5, 2020
Merged

Add Experimentation Service client #1934

merged 47 commits into from
May 5, 2020

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Apr 30, 2020 •
edited
Loading

  • Adds Experimentation Service client (and adapter)
  • Adds unified activity measurement service
  • Removes NPS and Active Use surveys (NPS will return - Start Survey to get user feedback and satisfaction #1854)
  • Guards more things based on user telemetry opt-in, in order to maximize respect of user privacy choice

@bwateratmsft bwateratmsft requested a review from a team as a code owner April 30, 2020 14:22
@bwateratmsft bwateratmsft added this to the 1.2.0 milestone Apr 30, 2020
@bwateratmsft bwateratmsft mentioned this pull request May 1, 2020
Closed
haniamr
haniamr approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@haniamr haniamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just a couple of small things that need clarification.

src/telemetry/ActivityMeasurementService.ts Outdated Show resolved Hide resolved
src/telemetry/ExperimentationServiceAdapter.ts Outdated Show resolved Hide resolved
src/telemetry/TelemetryReporterProxy.ts Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft self-assigned this May 4, 2020
@bwateratmsft bwateratmsft mentioned this pull request May 5, 2020
Merged
karolz-ms
karolz-ms requested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great; the only issue that I'd like to discuss is (not?) including telemetry from test runs

src/commands/registerCommands.ts Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
src/tasks/DockerTaskProvider.ts Show resolved Hide resolved
src/tasks/DockerTaskProvider.ts Show resolved Hide resolved
src/telemetry/ActivityMeasurementService.ts Outdated Show resolved Hide resolved
src/telemetry/ExperimentationServiceAdapter.ts Show resolved Hide resolved
src/telemetry/ExperimentationTelemetry.ts Outdated Show resolved Hide resolved
src/telemetry/ExperimentationTelemetry.ts Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit a14d9b7 into master May 5, 2020
@bwateratmsft bwateratmsft deleted the bmw/tas branch May 5, 2020 19:07
@bwateratmsft bwateratmsft removed their assignment May 5, 2020
This was referenced May 20, 2020
Closed
Closed
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@bwateratmsft @Dmarch28
Add Experimentation Service client (microsoft#1934)
ffa42c6 
* Create an adapter for TAS

* Add activity measurement service

* Refactoring

* Update dependencies

* Use registerEvent for save listener

* Remove ITelemetryReporter
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ravipal ravipal ravipal left review comments

@haniamr haniamr haniamr approved these changes

@karolz-ms karolz-ms karolz-ms approved these changes

@philliphoff philliphoff Awaiting requested review from philliphoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bwateratmsft @ravipal @haniamr @karolz-ms