Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Experimentation Service client #1934

Merged
merged 47 commits into from
May 5, 2020
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
5ccf37a
Add initial TAS client
bwateratmsft Apr 23, 2020
886748d
Create an adapter for TAS
bwateratmsft Apr 24, 2020
5207bc7
Merge branch 'master' into bmw/tas
bwateratmsft Apr 27, 2020
6834939
Use latest vscode-tas-client
bwateratmsft Apr 27, 2020
a1737db
Merge branch 'master' into bmw/tas
bwateratmsft Apr 27, 2020
74d8098
Correct merge from master
bwateratmsft Apr 27, 2020
4947f40
Use cached version per recommendation
bwateratmsft Apr 27, 2020
3c732ec
Add activity measurement service
bwateratmsft Apr 27, 2020
d7ef400
Refactoring
bwateratmsft Apr 27, 2020
1e15fcd
Actually record activity
bwateratmsft Apr 28, 2020
fa431e7
Add a missed call
bwateratmsft Apr 28, 2020
76627ba
Unrelated fix
bwateratmsft Apr 28, 2020
b0cb98e
Merge branch 'master' into bmw/tas
bwateratmsft Apr 29, 2020
6b9b5f9
Minor edits
bwateratmsft Apr 29, 2020
8f6d0c7
Best efforting
bwateratmsft Apr 29, 2020
72381b8
Order of ops
bwateratmsft Apr 29, 2020
932428a
Don't use assert
bwateratmsft Apr 29, 2020
2781bc3
Make activity service optional
bwateratmsft Apr 29, 2020
5f8046f
Merge branch 'master' into bmw/tas
bwateratmsft Apr 30, 2020
8ad3978
Remove deprecated code
bwateratmsft Apr 30, 2020
d4bd6af
Refactoring
bwateratmsft Apr 30, 2020
0ef8f4c
Fix test
bwateratmsft Apr 30, 2020
61f006e
Fix potential bug
bwateratmsft Apr 30, 2020
df994e6
Update dependencies
bwateratmsft Apr 30, 2020
905325b
Update tas client version
bwateratmsft Apr 30, 2020
6255718
Ravi's feedback
bwateratmsft May 1, 2020
03a6360
Use registerEvent for save listener
bwateratmsft May 1, 2020
80e58c8
Remove argument
bwateratmsft May 1, 2020
d043c05
Minor edits
bwateratmsft May 1, 2020
ad26d5c
Bugfix
bwateratmsft May 1, 2020
32d45d7
Minor change
bwateratmsft May 4, 2020
5002ce4
Merge branch 'master' into bmw/tas
bwateratmsft May 4, 2020
272fee1
Add tests and fix bugs
bwateratmsft May 4, 2020
1ce1d28
Fix some test bugs
bwateratmsft May 4, 2020
e0f3ef0
Hani's feedback
bwateratmsft May 4, 2020
038731f
Fix bug
bwateratmsft May 4, 2020
42af3c7
Implementing new model?
bwateratmsft May 4, 2020
e553aa4
Fix tests once and for all
bwateratmsft May 4, 2020
2edc652
Remove overkill caching
bwateratmsft May 4, 2020
9ad0a64
Rename function for cleaner PR
bwateratmsft May 4, 2020
173f4fa
Remove unneeded code
bwateratmsft May 4, 2020
863da75
Remove ITelemetryReporter
bwateratmsft May 4, 2020
9e81959
Update references to common packages
bwateratmsft May 5, 2020
321a472
Remove unneeded linter suppressions
bwateratmsft May 5, 2020
4f97851
Add UTs
bwateratmsft May 5, 2020
e3d16c4
Karol's feedback
bwateratmsft May 5, 2020
45b3b4b
Comment
bwateratmsft May 5, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions extension.bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ export { trimWithElipsis } from './src/utils/trimWithElipsis';
export { recursiveFindTaskByType } from './src/tasks/TaskHelper';
export { TaskDefinitionBase } from './src/tasks/TaskDefinitionBase';
export { DebugConfigurationBase } from './src/debugging/DockerDebugConfigurationBase';
export { TelemetryPublisher } from './src/telemetry/TelemetryPublisher';
export { TelemetryReporterProxy } from './src/telemetry/TelemetryReporterProxy';
export { ITelemetryPublisher, TelemetryEvent } from './src/telemetry/TelemetryPublisher';
export { activeUseSurvey } from './src/telemetry/surveys/activeUseSurvey';

export * from 'vscode-azureextensionui';
99 changes: 77 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2649,10 +2649,11 @@
"request-promise-native": "^1.0.8",
"semver": "^6.3.0",
"tar": "^6.0.1",
"vscode-azureappservice": "^0.57.6",
"vscode-azureextensionui": "^0.29.13",
"vscode-azureappservice": "^0.57.7",
"vscode-azureextensionui": "^0.30.1",
"vscode-languageclient": "^6.1.3",
"vscode-nls": "^4.1.2",
"vscode-tas-client": "^0.0.658",
"xml2js": "^0.4.23"
}
}
4 changes: 2 additions & 2 deletions src/commands/networks/createNetwork.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { window } from 'vscode';
import { IActionContext } from 'vscode-azureextensionui';
import { ext } from '../../extensionVariables';
import { localize } from '../../localize';
import { callDockerodeAsync, callDockerodeWithErrorHandling } from '../../utils/callDockerode';
import { callDockerodeWithErrorHandling } from '../../utils/callDockerode';

export async function createNetwork(context: IActionContext): Promise<void> {

Expand All @@ -16,7 +16,7 @@ export async function createNetwork(context: IActionContext): Promise<void> {
prompt: localize('vscode-docker.commands.networks.create.promptName', 'Name of the network')
});

const engineVersion = await callDockerodeAsync(async () => ext.dockerode.version());
const engineVersion = await callDockerodeWithErrorHandling(async () => ext.dockerode.version(), context);
const drivers = engineVersion.Os === 'windows'
? [
{ label: 'nat' },
Expand Down
Loading