Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrisdias/51v2 #53

Merged
merged 2 commits into from
Jan 4, 2017
Merged

Chrisdias/51v2 #53

merged 2 commits into from
Jan 4, 2017

Conversation

chrisdias
Copy link
Member

Made a better fix for #51 and bumped the version number so I can publish.

lostintangent
lostintangent approved these changes Jan 4, 2017
View reviewed changes
Copy link
Member

@lostintangent lostintangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisdias
Copy link
Member Author

I found another path problem with the fix for 51 which is why this is "better" :)

@chrisdias chrisdias merged commit bae341a into master Jan 4, 2017
@lostintangent
Copy link
Member

The code is cleaner is well, so it's a nice change all around 👍

@chrisdias chrisdias deleted the chrisdias/51v2 branch February 10, 2017 17:27
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lostintangent lostintangent lostintangent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdias @lostintangent @msftclas