Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update the doc for java-webapp to the latest #6005

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

silenceJialuo
Copy link
Contributor

This is Jialuo Gan here and I am the PM at Microsoft for Java on Azure Tooling. I have fixed all the issues to keep it up to date. Please wait for Java 17 runtime issues to be fixed and then merge this doc to the main. I will update it later.

@gregvanl
Copy link

gregvanl commented Mar 2, 2023

Hi @silenceJialuo I noticed that the two devicelogin .png images are also used in /docs/java/java-spring-apps.md and that tutorials also has the same login section as java-webapp.md.
Should java-spring-apps.md be updated the same way?

@silenceJialuo silenceJialuo dismissed a stale review via 35d5bf3 March 3, 2023 03:46
@silenceJialuo
Copy link
Contributor Author

Hi @gregvanl , thanks for your kind remainder. There are some differences in java-spring-apps.md compared with java-spring-apps.md. For Azure Spring Apps extension, we provide another explorer for users to sign in. I also update the login in sections in the file of java-spring-apps.md. And it's ready to merge.

@gregvanl gregvanl enabled auto-merge (squash) March 3, 2023 03:59
Copy link

@gregvanl gregvanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants