[Feature]: Add dropdown menu in title view containing link to settings and changelog #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidorteg
requested changes
Mar 10, 2021
There was a problem hiding this comment.
I like the change but I'm not sure if the toolbar is the best place for it, as it feels out of place with the other buttons (which are extension commands). I took a look to other extensions and some of them add a "..." menu at the end which triggers a context menu where we could add the changelog (along with maybe other options like "Settings"). similar to this:
mliao95
force-pushed
the
user/milia/changelog
branch
from
683375d
to
0761c35
Compare
mliao95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dropdown menu in the extension's title view that contains links to the extension's settings and changelog.
GIF:
closes #255