Fix issue of missing non important tool not resulting in prompt

microsoft · Feb 18, 2018 · de7f7a8 · de7f7a8
1 parent 6cc51f2
commit de7f7a8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
@@ -143,6 +143,7 @@ export function promptForMissingTool(tool: string) {
 			if (missing.indexOf(tool) === -1) {
 				return;
 			}
+			missing = missing.filter(x => x === tool || importantTools.indexOf(x) > -1);
 			if (missing.length > 1) {
 				items.push('Install All');
 			}
@@ -308,6 +309,7 @@ export function offerToInstallTools() {
 
 	getGoVersion().then(goVersion => {
 		getMissingTools(goVersion).then(missing => {
+			missing = missing.filter(x => importantTools.indexOf(x) > -1);
 			if (missing.length > 0) {
 				showGoStatus('Analysis Tools Missing', 'go.promptforinstall', 'Not all Go tools are available on the GOPATH');
 				vscode.commands.registerCommand('go.promptforinstall', () => {
@@ -352,8 +354,7 @@ function getMissingTools(goVersion: SemVersion): Promise<string[]> {
 			resolve(exists ? null : tool);
 		});
 	}))).then(res => {
-		let missing = res.filter(x => x != null && importantTools.indexOf(x) > -1);
-		return missing;
+		return res.filter(x => x != null);
 	});
 }