Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopping debug doesn't kill Code-OSS #554

Closed
roblourens opened this issue Jul 2, 2020 · 1 comment
Closed

Stopping debug doesn't kill Code-OSS #554

roblourens opened this issue Jul 2, 2020 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2020

Comments

@roblourens
Copy link
Member

  • Start the "Launch VS Code" config
  • Click stop button
  • The OSS window is closed but the app is still running

image
@connor4312
Copy link
Member

Fixed the setting but also changed the default following some user reports #555

@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Jul 3, 2020
@connor4312 connor4312 added this to the June 2020 milestone Jul 3, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 3, 2020
@connor4312 @gjsjohnmurray
debug: close whole vscode 'browser' when ending sessions
effd5ad 
Fixes microsoft/vscode-js-debug#554
@roblourens roblourens added the verified Verification succeeded label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
2 participants
@roblourens @connor4312