fix: skipFiles creating catastrophic regexes #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default skipFiles for extension host debugging create a pair of regexes, which compile down to something like: ``` /^(.+(\\/|$))*node_modules\\.asar\\/(.+(\\/|$))*$/i ``` The former part of this regex is a catastrophic lookahead, taking ~250ms to test against the test string. This fixes that and also adds a sanity unit test to ensure regexes run reasonably fast.
meganrogge
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default skipFiles for extension host debugging create a pair of
regexes, which compile down to something like:
The former part of this regex is a catastrophic lookahead, taking ~250ms
to test against the string included in the unit tests in this PR.
This fixes that and also adds a sanity unit test to ensure regexes run
reasonably fast.
Fixes #1469