Re-add code to download loc files in gulpfile.js for VS build #1622
Conversation
gulpfile.js
Outdated
| @@ -17,6 +17,10 @@ const util = require('util'); | |||
| const deepmerge = require('deepmerge'); | |||
| const esbuild = require('esbuild'); | |||
| const esbuildPlugins = require('./src/build/esbuildPlugins'); | |||
| const signale = require('signale'); | |||
| const got = require('got').default; | |||
| const unzipper = require('unzipper'); | |||
There was a problem hiding this comment.
It looks like this is missing in the package.jons.
Also, I would prefer using jszip over unzipper; in @vscode/test-electron we recently moved to jszip due to issues and CG alerts on the seemingly-abandoned unzipper package.
Usage of jszip in vscode-test: https://github.com/microsoft/vscode-test/blob/83f719c7364c316ae1736e75ef1a505ad88461f1/lib/download.ts#L278-L294
gulpfile.js
Outdated
| const distDir = 'dist'; | ||
| const distSrcDir = `${distDir}/src`; |
There was a problem hiding this comment.
These are defined as buildDir and buildSrcDir already
gulpfile.js
Outdated
|
|
||
| const buffer = new streamBuffers.WritableStreamBuffer(); | ||
| const locale = match[1]; | ||
| entry.pipe(buffer).on('finish', () => { |
There was a problem hiding this comment.
You can use the pipeline method of streams, as in the code example I linked above, instead of manual pipes 🙂
|
Thanks! Code changes look good, but it looks like you |
No description provided.