Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fnm support #1737

Merged
merged 5 commits into from
Jul 2, 2023
Merged

Feat/fnm support #1737

merged 5 commits into from
Jul 2, 2023

Conversation

thales-maciel
Copy link
Contributor

Implements support for fnm node manager

This closes #847.

@thales-maciel
Copy link
Contributor Author

@microsoft-github-policy-service agree

@thales-maciel
Copy link
Contributor Author

I'm sorry about the commit spam, I couldn't run the tests locally for some reason.

@connor4312
Copy link
Member

No worries. This week is release week, I will review this next week. Thanks for the PR! :)

Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple Windows-specific tweaks :)

src/targets/node/nvmResolver.ts Outdated Show resolved Hide resolved
src/targets/node/nvmResolver.ts Outdated Show resolved Hide resolved
@connor4312 connor4312 enabled auto-merge July 1, 2023 04:58
@connor4312
Copy link
Member

Thanks!

Failing tests are a result of version constraints and will be fixed with the release next week (or if I make a PR in the meantime)

@connor4312 connor4312 merged commit 3eb6b8a into microsoft:main Jul 2, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FNM Node Version Manager in Node configuration provider
3 participants