Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process picker broken on some Linux distros #1753

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

thenbe
Copy link
Contributor

@thenbe thenbe commented Jul 9, 2023

Fixes #1752
Also see #1747

@thenbe
Copy link
Contributor Author

thenbe commented Jul 9, 2023

@microsoft-github-policy-service agree

@@ -43,7 +43,7 @@ export class DarwinProcessTree extends BaseProcessTree {
* @inheritdoc
*/
protected createProcess() {
return this.spawn('/bin/ps', [
return this.spawn('ps', [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware this is the darwin file, but I figured we might as well be consistent.

connor4312
connor4312 previously approved these changes Jul 10, 2023
@connor4312
Copy link
Member

It looks like there are some failing tests. Two of those are on main, which I will fix, but there's a few new ones with the NodeBinaryProvider

  3) NodeBinaryProvider
       rejects not found:
     AssertionError: expected Error: expected to throw to be an instance of ProtocolError
      at Context.<anonymous> (src/targets/node/nodeBinaryProvider.test.ts:2:1478)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  4) NodeBinaryProvider
       rejects outdated:
     AssertionError: expected Error: expected to throw to be an instance of ProtocolError
      at Context.<anonymous> (src/targets/node/nodeBinaryProvider.test.ts:2:1793)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  5) NodeBinaryProvider
       works if up to date:

      AssertionError: expected 'node' to equal '/home/vsts/work/1/s/testWorkspace/nod…'
      + expected - actual

      -node
      +/home/vsts/work/1/s/testWorkspace/nodePathProvider/up-to-date/node
      
      at Context.<anonymous> (src/targets/node/nodeBinaryProvider.test.ts:2:2978)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  6) NodeBinaryProvider
       resolves the binary if given a package manager:

@thenbe
Copy link
Contributor Author

thenbe commented Jul 12, 2023

Yup I see them. I'll have to take a closer look at them on a mac (on my nix machine, those tests and a bunch more are failing even before this commit).

@connor4312
Copy link
Member

Thanks!

@connor4312 connor4312 enabled auto-merge (squash) July 13, 2023 14:42
@connor4312 connor4312 merged commit 1abd10e into microsoft:main Jul 13, 2023
7 checks passed
@thenbe thenbe deleted the replace-hardcoded-paths branch July 13, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process picker broken on nixOS
4 participants