-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process picker broken on some Linux distros #1753
Conversation
@microsoft-github-policy-service agree |
@@ -43,7 +43,7 @@ export class DarwinProcessTree extends BaseProcessTree { | |||
* @inheritdoc | |||
*/ | |||
protected createProcess() { | |||
return this.spawn('/bin/ps', [ | |||
return this.spawn('ps', [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware this is the darwin file, but I figured we might as well be consistent.
It looks like there are some failing tests. Two of those are on main, which I will fix, but there's a few new ones with the NodeBinaryProvider
|
Yup I see them. I'll have to take a closer look at them on a mac (on my nix machine, those tests and a bunch more are failing even before this commit). |
Thanks! |
Fixes #1752
Also see #1747