Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change no-unused-vars lint rule to a warning #12048

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Change no-unused-vars lint rule to a warning #12048

merged 1 commit into from
Nov 17, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 16, 2022

It's quite distracting having an unused variable error appear, this should be a warning as it's normally just a dev time thing. Committing should reject all warnings anyway.

image

It's quite distracting having an unused variable error appear, this should be a warning as it's normally just a dev time thing. Committing should reject all warnings anyway.
@Tyriar Tyriar added this to the November 2022 milestone Nov 16, 2022
@Tyriar Tyriar requested a review from rebornix November 16, 2022 20:36
@Tyriar Tyriar self-assigned this Nov 16, 2022
@Tyriar Tyriar enabled auto-merge (squash) November 16, 2022 20:39
@codecov-commenter
Copy link

Codecov Report

Merging #12048 (3bd8742) into main (503220a) will increase coverage by 15%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #12048     +/-   ##
========================================
+ Coverage     47%      62%    +15%     
========================================
  Files        502      502             
  Lines      35918    35918             
  Branches    5813     5813             
========================================
+ Hits       16908    22594   +5686     
+ Misses     17399    11193   -6206     
- Partials    1611     2131    +520     
Impacted Files Coverage Δ
src/platform/common/platform/fs-paths.node.ts 64% <0%> (ø)
src/platform/vscode-path/map.ts 10% <0%> (+<1%) ⬆️
src/platform/logging/index.ts 75% <0%> (+<1%) ⬆️
src/kernels/serviceRegistry.node.ts 100% <0%> (+1%) ⬆️
...platform/interpreter/reservedNamedProvider.node.ts 93% <0%> (+1%) ⬆️
src/platform/vscode-path/resources.ts 40% <0%> (+1%) ⬆️
...ernels/raw/session/hostRawNotebookProvider.node.ts 86% <0%> (+1%) ⬆️
src/kernels/kernelProvider.node.ts 100% <0%> (+1%) ⬆️
src/platform/common/utils.ts 79% <0%> (+1%) ⬆️
...preter/jupyterInterpreterDependencyService.node.ts 75% <0%> (+1%) ⬆️
... and 271 more

@Tyriar Tyriar merged commit d8385e9 into main Nov 17, 2022
@Tyriar Tyriar deleted the Tyriar-patch-1 branch November 17, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants