Add Haskell to LanguageKind #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a maintainer of the Haskell language server, I would like to be able to name my language :D
dbaeumer
requested changes
Feb 8, 2024
| @@ -1929,6 +1929,7 @@ export namespace LanguageKind { | |||
| export const Go = 'go' as const; | |||
| export const Groovy = 'groovy' as const; | |||
| export const Handlebars = 'handlebars' as const; | |||
| export const Haskell = 'haskell' as const; | |||
There was a problem hiding this comment.
The whole enum has @since 3.18 and @proposed, so are the individual entries not all implicitly the same? It seems a bit odd that only a few of the entries have those annotations: shouldn't all of them have it or none of them?
|
We also need to update the specification. Can you provide a PR for this as well? |
|
Sure. |
|
The current version of the 3.18 spec doesn't have |
|
That is correct. It maintains it as a table here: https://github.com/microsoft/language-server-protocol/blob/9c5689e6f6f93102a67a652e3d9c6e2b95c2b2eb/_specifications/lsp/3.18/types/textDocumentItem.md#L32 |
|
Got it: PR here: microsoft/language-server-protocol#1898 |
dbaeumer
approved these changes
Feb 13, 2024
alexr00
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a maintainer of the Haskell language server, I would like to be able to name my language :D