Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Haskell to LanguageKind #1421

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add Haskell to LanguageKind #1421

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
806fbeb
Add Haskell to LanguageKind
michaelpj Feb 7, 2024
8ae0d5d
Merge branch 'main' into mpj/haskell-is-a-languages
dbaeumer Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions types/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,6 +1929,7 @@ export namespace LanguageKind {
export const Go = 'go' as const;
export const Groovy = 'groovy' as const;
export const Handlebars = 'handlebars' as const;
export const Haskell = 'haskell' as const;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs @SInCE and @proposed. See D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole enum has @since 3.18 and @proposed, so are the individual entries not all implicitly the same? It seems a bit odd that only a few of the entries have those annotations: shouldn't all of them have it or none of them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

export const HTML = 'html' as const;
export const Ini = 'ini' as const;
export const Java = 'java' as const;
Expand Down