Aligns language server with protocol proposition #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaeumer
requested changes
Apr 14, 2020
|
@giltho should we for consistency change this one as well? https://github.com/microsoft/vscode-languageserver-node/blob/master/jsonrpc/src/main.ts#L262 |
|
Yes I think it would be better indeed. Also, I could probably add it to the protocol proposition. |
|
That would be great! |
|
I updated the draft here microsoft/language-server-protocol#953 :) |
|
@giltho could you resolve the conflict please. |
giltho
force-pushed
the
specified-logtrace
branch
from
c80e52c
to
98d6b40
Compare
|
@dbaeumer done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the server with microsoft/language-server-protocol#953