Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source.cpp contentName #47

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Add source.cpp contentName #47

merged 2 commits into from
Aug 27, 2019

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 11, 2019

This will provide better C++ syntax highlighting within markdown.
Full context: microsoft/vscode#76603 (comment)

@alexr00 alexr00 requested a review from mjbvz July 11, 2019 13:26
@mjbvz
Copy link
Contributor

mjbvz commented Jul 11, 2019

The main grammar is actually generated using this script: https://github.com/microsoft/vscode-markdown-tm-grammar/blob/master/build.js Could you please look into updating that script too so we don't loose this fix when we next generate the grammar

@alexr00
Copy link
Member Author

alexr00 commented Jul 12, 2019

Yes, will do!

@alexr00
Copy link
Member Author

alexr00 commented Aug 27, 2019

Updated!

@mjbvz mjbvz merged commit b124933 into master Aug 27, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Aug 27, 2019

Thanks! I'll pull in the grammar for the VS Code August release

mjbvz added a commit to microsoft/vscode that referenced this pull request Aug 27, 2019
@alexr00 alexr00 deleted the alexr00-patch-1 branch August 28, 2019 07:59
hunghw pushed a commit to hunghw/vscode that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants