Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrongly prepend /mnt to pom path #874

Closed
grimly opened this issue Sep 13, 2022 · 3 comments · Fixed by #875
Closed

Wrongly prepend /mnt to pom path #874

grimly opened this issue Sep 13, 2022 · 3 comments · Fixed by #875
Assignees
Labels
bug Something isn't working

Comments

@grimly
Copy link

grimly commented Sep 13, 2022

Describe the bug
When git for windows is installed with a custom path, the transformation of the pom path to wsl is attempted.

To Reproduce
Steps to reproduce the behavior:

  1. Install git for windows in a path not including Git and set it as default shell
  2. Run any goal from a maven project
  3. See maven complain about a path (starting with /mnt) not existing

Expected behavior
If detection is not possible, allow a setting to disable WSL path transformation

Environments (please complete the following information as much as possible):

  • OS: Windows 10
  • VS Code version: 1.71.0
  • Extension version: 0.38.0

Screenshots

Additional context
I have no control over the path to the shell and wsl is not enabled (organization ruling)

@Eskibear Eskibear added the bug Something isn't working label Sep 13, 2022
@Eskibear
Copy link
Member

case "bash.exe":
case "wsl.exe":
if (currentWindowsShellPath.indexOf("Git") > 0) {
return ShellType.GIT_BASH;
}
return ShellType.WSL;
default:
return ShellType.OTHERS;

@Eskibear
Copy link
Member

we need a more reliable way to check if it's git-bash

@Eskibear Eskibear self-assigned this Sep 13, 2022
@Eskibear
Copy link
Member

Eskibear added a commit that referenced this issue Sep 14, 2022
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear Eskibear added this to the September 2022 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants