Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged pull request should use past tense #1027

Closed
meaghanlewis opened this issue Mar 5, 2019 · 0 comments · Fixed by #1209
Closed

Merged pull request should use past tense #1027

meaghanlewis opened this issue Mar 5, 2019 · 0 comments · Fixed by #1209
Assignees
@smashwilson
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@meaghanlewis
Copy link
Member

  • Extension version:
  • VSCode Version:
  • OS: MacOS

Steps to Reproduce:

  1. Merge an open pull request
  2. View pull request header

screen shot 2019-03-04 at 9 35 03 pm

Compared with GitHub.com:
screen shot 2019-03-05 at 8 26 45 am

Expected result:
meaghanlewis merged changes (instead of meaghanlewis wants to merge)
@meaghanlewis meaghanlewis added the bug Issue identified by VS Code Team member as probable bug label Mar 5, 2019
@smashwilson smashwilson self-assigned this Jun 4, 2019
@smashwilson smashwilson mentioned this issue Jun 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smashwilson smashwilson

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change "wants to merge" text when viewing merged PR microsoft/vscode-pull-request-github
2 participants
@smashwilson @meaghanlewis