Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating comment failed: Error: No matching file found #1308

Closed
antonioalwan opened this issue Aug 14, 2019 · 1 comment · Fixed by #1327
Closed

Creating comment failed: Error: No matching file found #1308

antonioalwan opened this issue Aug 14, 2019 · 1 comment · Fixed by #1327
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@antonioalwan
Copy link

I get this error when adding a comment.
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Aug 14, 2019
@RMacfarlane RMacfarlane self-assigned this Sep 4, 2019
@RMacfarlane
Copy link
Contributor

Reliable repro steps:

  1. Expand a pull request and open a file
  2. Collapse the pull request
  3. Click the button on the tree to refresh the pull request view
  4. In the still open file, try to add a comment

@RMacfarlane RMacfarlane mentioned this issue Sep 4, 2019
Merged
RMacfarlane pushed a commit that referenced this issue Sep 5, 2019
Make sure fileChanges are initialized for pull request nodes, fixes #…
3bc2d96 
…1308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure fileChanges are initialized for pull request nodes microsoft/vscode-pull-request-github
2 participants
@RMacfarlane @antonioalwan