Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the tab of Pull Request using Ctrl+W shortcut, closes the underlying tab too #1606

Closed
DavideViolante opened this issue Apr 6, 2020 · 1 comment

Comments

@DavideViolante
Copy link

DavideViolante commented Apr 6, 2020

  • Extension version: 0.15.0
  • VSCode Version: 1.43.2
  • OS: Ubuntu 18.04

Steps to Reproduce:

  1. Open a PR using this extension
  2. Try closing the PR tab (not the PR itself) using the keyboard shortcut Ctrl+W (I think on Mac is Cmd+W)
  3. This will close VS Code if the PR tab is the only one open, or will close the underlying tab currently opened. The expected behaviour is that Ctrl+W will close the PR tab only.

GIF (I just press Ctrl+W):
closingtab

I couldnt find the issue already opened, sorry if there is already.

@DavideViolante
Copy link
Author

I just noticed that this bug seems related to VS Code itself: microsoft/vscode#86790 and many more similar issues are present in vscode repo already. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant