Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squash and merge missing the PR number in the commit title #1828

Closed
felipecrs opened this issue May 23, 2020 · 0 comments · Fixed by #1924
Closed

Squash and merge missing the PR number in the commit title #1828

felipecrs opened this issue May 23, 2020 · 0 comments · Fixed by #1924
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2020

Comments

@felipecrs
Copy link
Contributor

  • Extension version: 0.16.0
  • VSCode Version: 1.45.1
  • OS: Windows 10 x64

Steps to Reproduce:

  1. Create a Pull Request
  2. Try to merge with squash

Check the commit title of the squash, it's missing the PR number as the web UI does.

adyQdYJSAO
This was referenced Jun 19, 2020
Merged
Closed
RMacfarlane pushed a commit that referenced this issue Jun 23, 2020
@felipecrs
Fix pr title in squash merge, fixes #1828
6f95c98
@RMacfarlane RMacfarlane added this to the June 2020 milestone Jun 23, 2020
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Jun 23, 2020
@rebornix rebornix added the verified Verification succeeded label Jul 2, 2020
alexr00 pushed a commit that referenced this issue Jul 9, 2020
@felipecrs @alexr00
Fix pr title in squash merge, fixes #1828
2079e4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

Fix pr title in squash merge
3 participants
@rebornix @RMacfarlane @felipecrs