Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a gist repository gives a fetch error #2324

Closed
mcornella opened this issue Dec 13, 2020 · 11 comments · Fixed by #2933
Closed

Opening a gist repository gives a fetch error #2324

mcornella opened this issue Dec 13, 2020 · 11 comments · Fixed by #2933
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@mcornella
Copy link

Issue Type: Bug

  1. Clone a wiki (adding .wiki.git to a main repository URL) or gist repository
  2. Open the cloned repository with VS Code with the extension enabled
  3. See error: Fetching pull requests for remote 'origin' failed, please check if the url <URL> is valid.

Wiki repository:
image

Gist repository:
image

Extension version: 0.22.0
VS Code version: Code - Insiders 1.52.0-insider (bc13785d3dd99b4b0e9da9aed17bb79809a50804, 2020-12-07T14:46:48.305Z)
OS version: Windows_NT x64 10.0.20262
Remote OS version: Linux x64 4.19.128-microsoft-standard
Remote OS version: Linux x64 4.19.128-microsoft-standard
Remote OS version: Linux x64 4.19.128-microsoft-standard

System Info
Item Value
CPUs Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz (4 x 2394)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: unavailable_off
opengl: enabled_on
protected_video_decode: enabled
rasterization: unavailable_off
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: unavailable_off
Load (avg) undefined
Memory (System) 7.92GB (1.69GB free)
Process Argv --folder-uri=vscode-remote://wsl+Ubuntu/home/marc/code/refined-github --remote=wsl+Ubuntu --crash-reporter-id b50261c5-4e04-48dd-9f0a-6d441b513f94
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.128-microsoft-standard
CPUs Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz (4 x 2393)
Memory (System) 3.80GB (1.30GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.128-microsoft-standard
CPUs Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz (4 x 2393)
Memory (System) 3.80GB (1.30GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.19.128-microsoft-standard
CPUs Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz (4 x 2393)
Memory (System) 3.80GB (1.30GB free)
VM 0%
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221882
python763:30178808
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30208929
wsl2promptcf:30219163
vstry914:30230485
pythonvsdeb440:30224570
unusedpromptcf:30219165
folderexplorercf:30219167
openfilemenu:30219168
pythonvsded773:30223139
pythonvspyt600cf:30228412
core-portspanelcf:30233468

@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2020
@ghost
Copy link

ghost commented Mar 26, 2021

issue is still there... any tricks around it?

@bensherman
Copy link

Came to report this issue - maybe we can add an ignore on repos that end in .wiki?

@mcornella
Copy link
Author

This doesn't happen to me anymore on 0.26.0, can you check if upgrading works?

@alexr00
Copy link
Member

alexr00 commented Aug 13, 2021

Should be fixed for wiki, but I haven't made any changes for gists.

@mcornella
Copy link
Author

Yeah that's true, I hadn't checked on gists. I'll update the title.

@mcornella mcornella changed the title Opening a wiki or gist repository gives an error Opening a gist repository gives a fetch error Aug 13, 2021
@burkeholland burkeholland self-assigned this Aug 20, 2021
@burkeholland
Copy link
Collaborator

burkeholland commented Aug 20, 2021

OK! So this turned out to be harder than I thought. Gists can be cloned in two different ways so the remote might look different.

  1. Clone via gist.github.com (i.e. https://gist.github.com/burkeholland/efcf2bc7fd9a3d84ecd9756f83f97551)
  2. Clone via github.com (i.e. git@github.com:c8456e08df200c7fd718dac69bbfc5a0.git)

1 is easy enough to account for. 2 is a bit harder as I'm not sure if gist id's follow a certain pattern.

@mcornella
Copy link
Author

mcornella commented Aug 20, 2021

2. Clone via github.com (i.e. git@github.com:c8456e08df200c7fd718dac69bbfc5a0.git)

In my example the SSH remote uses gist.github.com, and so it does when using the Clone via SSH button:
Captura de pantalla de 2021-08-20 22-40-47

Meaning maybe the github.com clone works, but the default is using gist.github.com, so fixing that would be enough I think.

Also the example you posted does not contain a slash in the repository part of the remote URL, so maybe that can also be checked.

@alexr00
Copy link
Member

alexr00 commented Aug 23, 2021

Let's solve for the the simple case and take the incremental improvement. I agree that I don't see a clear solution for (2) above.

@burkeholland
Copy link
Collaborator

Does a match for gist[.]github[.]com. If you clone from github.com, YMMV.

@roblourens
Copy link
Member

roblourens commented Dec 1, 2021

I don't get an error. Should I see this when I cloned a wiki or gist?

image

@roblourens roblourens added the verified Verification succeeded label Dec 1, 2021
@alexr00
Copy link
Member

alexr00 commented Dec 2, 2021

What you're seeing is correct. We don't provide GitHub support when you open a wiki or gist, and I think most people don't expect there to be support for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants