Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments created with "Add a Comment" say "pending" #2822

Closed
alexr00 opened this issue Jul 5, 2021 · 6 comments · Fixed by #2823
Closed

Comments created with "Add a Comment" say "pending" #2822

alexr00 opened this issue Jul 5, 2021 · 6 comments · Fixed by #2823
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Jul 5, 2021

  1. Open a PR where you haven't started a review.
  2. Add a comment using the commenting widget and the "Add a Comment" button.
  3. The comment will add. ✅
  4. A moment later, the comment will say "Pending". ❌
    image
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jul 5, 2021
@alexr00 alexr00 added this to the July 2021 milestone Jul 5, 2021
@alexr00 alexr00 self-assigned this Jul 5, 2021
@alexr00
Copy link
Member Author

alexr00 commented Jul 5, 2021

There are two things going on here:

  1. When we add the comment, there is a quirk of GitHub that briefly makes the comment a "pending" comment. This is just part of the API and is expected. Once the review is submitted (there is a hidden review associated with single comments, this is also just the way it works), then the comment is no longer pending. We do properly submit the review; however these leads to the second thing that's going on...
  2. After the review is submitted and the comment is no longer "pending" we should update the associated comment threads. We are not doing that and this is a bug.

So, in short, what should happen:

  1. The comment is added and doesn't show "Pending".
  2. A moment later, it does show "Pending".
  3. A moment after that, "Pending" goes away again.

@negiraju
Copy link

Hey, this is test comment

@IvanZhantalay
Copy link

test

3 similar comments
@Cuongdc89
Copy link

test

@zhwuwuwu
Copy link

test

@Pony-Qinpeng
Copy link

test

@microsoft microsoft locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants