Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing focus/switching tabs while a comment entered (but not submitted) loses comment #3200

Closed
catskul opened this issue Dec 17, 2021 · 1 comment · Fixed by #3216
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@catskul
Copy link

catskul commented Dec 17, 2021

  • Extension version: v0.35.2021121609
  • VSCode Version:Version: 1.64.0-insider
  • Commit: f67a8b753f55e452f38b61497662839c4691fb12
  • Date: 2021-12-16T05:15:28.698Z
  • Electron: 13.5.2
  • Chromium: 91.0.4472.164
  • Node.js: 14.16.0
  • V8: 9.1.269.39-electron.0
  • OS: Linux x64 5.4.0-91-generic

Steps to Reproduce:

  1. starting editing a reply to a review comment.
  2. switch to a different tab
  3. return to tab with comment box
  4. work is gone
@alexr00 alexr00 self-assigned this Dec 20, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 20, 2021
@alexr00 alexr00 added this to the January 2022 milestone Dec 20, 2021
@alexr00
Copy link
Member

alexr00 commented Dec 30, 2021

I've added a small cache for comments in non-visible files in a PR. However, the cache will only preserve 1 diffs worth of comments. This means that if you click switch tabs once while writing a reply, your reply won't be lost. But if you switch tabs twice while writing a reply it will be lost. If we find that this cache is too limited, we can expand it, but any expansion will come at the cost of minor perf losses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants