Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments appear being pending instead of submitted #3232

Closed
shiyao-afterpay opened this issue Jan 6, 2022 · 1 comment · Fixed by #3235
Closed

Comments appear being pending instead of submitted #3232

shiyao-afterpay opened this issue Jan 6, 2022 · 1 comment · Fixed by #3235
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2022

Comments

@shiyao-afterpay
Copy link

After I started a review, and added some comments, then finally when I submit the review in this panel (the bottom left one in VSC).
image

The comments are pending instead of submitted.
@alexr00 alexr00 self-assigned this Jan 7, 2022
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jan 7, 2022
@alexr00 alexr00 added this to the January 2022 milestone Jan 7, 2022
@alexr00
Copy link
Member

alexr00 commented Jan 7, 2022

Thanks for filing this bug!

alexr00 added a commit that referenced this issue Jan 7, 2022
@alexr00
Comments pending instead of submitted
7172968 
Fixes #3232
@alexr00 alexr00 mentioned this issue Jan 7, 2022
Merged
@tanhakabir tanhakabir added the verified Verification succeeded label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Comments pending instead of submitted microsoft/vscode-pull-request-github
3 participants
@tanhakabir @alexr00 @shiyao-afterpay