Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't leave a comment in PR webviewview without a pending review #3480

Closed
TylerLeonhardt opened this issue Apr 21, 2022 · 0 comments · Fixed by #3493
Closed

Can't leave a comment in PR webviewview without a pending review #3480

TylerLeonhardt opened this issue Apr 21, 2022 · 0 comments · Fixed by #3493
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2022

Comments

@TylerLeonhardt
Copy link
Member

  • Extension version: v0.41.2022041309
  • VSCode Version: 1.67.0-insiders
  • OS: web

Steps to Reproduce:

  1. Don't have a pending review
  2. try to leave a comment:
    image

I expected this to still work (and leave a normal comment on the PR)... instead it errors saying I don't have a review in progress
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Apr 22, 2022
@alexr00 alexr00 self-assigned this Apr 22, 2022
@alexr00 alexr00 added this to the April 2022 milestone Apr 22, 2022
alexr00 added a commit that referenced this issue Apr 26, 2022
@alexr00
Can't leave a comment in PR webviewview without a pending review
b5751f5 
Fixes #3480
@alexr00 alexr00 mentioned this issue Apr 26, 2022
Merged
alexr00 added a commit that referenced this issue Apr 26, 2022
@alexr00
Can't leave a comment in PR webviewview without a pending review (#3493)
c06df98 
Fixes #3480
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2022
2 participants
@TylerLeonhardt @alexr00