Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text suggestions load forever on first column #3485

Closed
joaomoreno opened this issue Apr 22, 2022 · 5 comments · Fixed by #3486
Closed

Text suggestions load forever on first column #3485

joaomoreno opened this issue Apr 22, 2022 · 5 comments · Fixed by #3486
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Recording 2022-04-22 at 06 47 52

@jrieken jrieken added the info-needed Issue requires more information from poster label Apr 22, 2022
@jrieken
Copy link
Member

jrieken commented Apr 22, 2022

not for me... any bad extension you are running?

@joaomoreno joaomoreno assigned alexr00 and unassigned jrieken Apr 22, 2022
@joaomoreno
Copy link
Member Author

Enabling trace logging:

[2022-04-22 14:29:19.059] [exthost] [trace] [GitHub.vscode-pull-request-github] INVOKE provider 'oe=>oe.provideCompletionItems(d.URI.revive(q),J,te,K)'
[2022-04-22 14:29:19.060] [exthost] [trace] [GitHub.vscode-pull-request-github] INVOKE provider 'oe=>oe.provideCompletionItems(d.URI.revive(q),J,te,K)'

Seems like that never returns.

Disabling GHPR fixes it.

@joaomoreno joaomoreno removed the info-needed Issue requires more information from poster label Apr 22, 2022
@alexr00 alexr00 transferred this issue from microsoft/vscode Apr 25, 2022
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Apr 25, 2022
@alexr00 alexr00 added this to the April 2022 milestone Apr 25, 2022
@alexr00
Copy link
Member

alexr00 commented Apr 25, 2022

Required setup to repro:

  1. Install GHRPI
  2. Sign in with GHPRI
  3. Open a folder without a git repo.

@rchiodo
Copy link

rchiodo commented Apr 27, 2022

@alexr00 I can't repro the initial problem (using this version of GHPRI and stable VS code):

Name: GitHub Pull Requests and Issues
Id: GitHub.vscode-pull-request-github
Description: Pull Request and Issue Provider for GitHub
Version: 0.40.0
Publisher: GitHub
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github

Do I need a specific version to repro?

@joaomoreno
Copy link
Member Author

Fixed it for me!

@joaomoreno joaomoreno added the verified Verification succeeded label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants