Opened up a Codespace with a GH PR and was asked to sign in to GHES

[TylerLeonhardt]

I think this is because I have settings sync turned on and it picked up the GHES setting from when I was testing it out.

I don't think this should happen in Codespaces at all.

[alexr00]

I think the GHES setting should probably a workspace only setting. @TylerLeonhardt what do you think?

[TylerLeonhardt]

@alexr00 I actually can't make it a workspace yet because I don't store the GHES uri with the session at the moment. Actually storing the GHES uri along with the session would probably be help in #3992 (comment) as well

[TylerLeonhardt]

@alexr00 as discussed we can't actually make something "workspace setting" only... so we'll need to handle this somehow when the user has this setting set to not prompt.

[alexr00]

Hmm. Does it make sense to set this setting to not sync? I can also prioritize the "is github.com" check over the "has enterprise uri" check.

[TylerLeonhardt]

Does it make sense to set this setting to not sync?

Can I do that while still allowing it to be set in workspace settings? I don't think so... @sandy081?

[sandy081]

Settings scoped to machine or machine-overridable are not synced by default.