Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress feedback on PR description actions #4954

Closed
alexr00 opened this issue Jun 26, 2023 · 5 comments · Fixed by #5205
Closed

Progress feedback on PR description actions #4954

alexr00 opened this issue Jun 26, 2023 · 5 comments · Fixed by #5205
Assignees
@alexr00
Labels
feature-request Request for new features or functionality polish verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 26, 2023

For example, when you change the automerge state we should show some progress then show the updated value. This is how github.com does it:

chrome_a9OpnVnu1i
@alexr00 alexr00 added feature-request Request for new features or functionality polish labels Jun 26, 2023
@alexr00 alexr00 added this to the July 2023 milestone Jun 26, 2023
@alexr00 alexr00 self-assigned this Jun 26, 2023
@alexr00 alexr00 modified the milestones: July 2023, August 2023 Jul 24, 2023
@alexr00
Copy link
Member Author

alexr00 commented Aug 28, 2023

New behavior:
Recording 2023-08-28 at 16 09 13

@alexr00 alexr00 mentioned this issue Aug 28, 2023
Merged
alexr00 added a commit that referenced this issue Aug 28, 2023
@alexr00
Add progress feedback on automerge
e8c59af 
Fixes #4954
alexr00 added a commit that referenced this issue Aug 28, 2023
@alexr00
Add progress feedback on automerge (#5205)
97f1ecb 
Fixes #4954
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Aug 28, 2023
@meganrogge
Copy link
Contributor

meganrogge commented Aug 29, 2023 •
edited

@alexr00 i'm not seeing that... on version v0.71.2023082809

auto-merge.mov

@meganrogge meganrogge added the verification-found Issue verification failed label Aug 29, 2023
@alexr00
Copy link
Member Author

alexr00 commented Aug 29, 2023

v0.71.2023082809 is from yesterday, you'll need today's build for the change.

@alexr00 alexr00 removed the verification-found Issue verification failed label Aug 29, 2023
@alexr00
Copy link
Member Author

alexr00 commented Aug 29, 2023

Looks like today's build failed. Looking...

@joyceerhl joyceerhl added verified Verification succeeded and removed verified Verification succeeded labels Aug 29, 2023
@alexr00
Copy link
Member Author

alexr00 commented Aug 29, 2023

New build is available.

@roblourens roblourens added the verified Verification succeeded label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality polish verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Add progress feedback on automerge microsoft/vscode-pull-request-github
4 participants
@roblourens @meganrogge @joyceerhl @alexr00