Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote reply missing for some comments #5012

Closed
brianjmurrell opened this issue Jul 6, 2023 · 0 comments · Fixed by #5073
Closed

Quote reply missing for some comments #5012

brianjmurrell opened this issue Jul 6, 2023 · 0 comments · Fixed by #5073
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
July 2023

Comments

@brianjmurrell
Copy link

  • Extension version:
  • VSCode Version:
  • OS:

Steps to Reproduce:

  1. Open PR Description page
  2. Hover over various comments
  3. Observe that some allow a quote reply and others do not

One that does:

image

One that does not:

image

(I was hovering on the comment title-bar when I took that screen shot, same as I was in the previous one).
@alexr00 alexr00 self-assigned this Jul 10, 2023
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jul 10, 2023
@alexr00 alexr00 added this to the July 2023 milestone Jul 10, 2023
@alexr00 alexr00 mentioned this issue Jul 18, 2023
Merged
alexr00 added a commit that referenced this issue Jul 18, 2023
@alexr00
Quote reply missing for some comments
1ae015f 
Fixes #5012
alexr00 added a commit that referenced this issue Jul 18, 2023
@alexr00
Quote reply missing for some comments (#5073)
ac00ba5 
Fixes #5012
@sandy081 sandy081 added the verified Verification succeeded label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Quote reply missing for some comments microsoft/vscode-pull-request-github
3 participants
@brianjmurrell @sandy081 @alexr00