Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Permalink fails frequently, seemingly on the first copy of the day #5185

Closed
Tyriar opened this issue Aug 18, 2023 · 7 comments 路 Fixed by #5562
Closed

Copy Permalink fails frequently, seemingly on the first copy of the day #5185

Tyriar opened this issue Aug 18, 2023 · 7 comments 路 Fixed by #5562
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug papercut 馃└ A particularly annoying issue impacting someone on the team verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2023

Typical repro (I haven't nailed it down entirely):

  1. Have VS Code open
  2. Put PC to sleep in afternoon
  3. Wake it up in the morning
  4. Select a code section
  5. GitHub Issues: Copy GitHub Permalink, 馃悰 fails sometimes

I have been hitting this for literally years and it's one of my biggest papercuts, but since it's such a pain to reproduce I never end up following it up after mentioning it. Since it's so annoying I think it's worth spending a couple of hours in a debug session together, restarting my computer if that's what it takes.

Trace logs:

GitHub Pull Request:

2023-08-18 05:15:54.267 [debug] GitHubRepository> Fetch pull request 190609 - enter
2023-08-18 05:15:54.269 [debug] RateLimit> Extension rate limit remaining: 140, PullRequest
2023-08-18 05:15:54.759 [debug] RateLimit> GraphQL Rate limit remaining: 4740, PullRequest
2023-08-18 05:15:54.760 [debug] GitHubRepository> Fetch pull request 190609 - done
2023-08-18 05:15:54.762 [debug] RateLimit> Extension rate limit remaining: 140, GetBranch
2023-08-18 05:15:55.025 [debug] RateLimit> GraphQL Rate limit remaining: 4739, GetBranch
2023-08-18 05:15:55.025 [debug] PullRequestModel> Fetch file changes, base, head and merge base of PR #190609 - enter
2023-08-18 05:15:55.025 [debug] IssueModel> Fetch viewers latest review commit
2023-08-18 05:15:55.026 [debug] RateLimit> Extension rate limit remaining: 140, LatestReviewCommit
2023-08-18 05:15:55.399 [debug] RateLimit> GraphQL Rate limit remaining: 4738, LatestReviewCommit
2023-08-18 05:15:55.666 [debug] RateLimit> Extension rate limit remaining: 140, PullRequestComments
2023-08-18 05:15:55.666 [debug] RateLimit> Extension rate limit remaining: 139, PullRequestComments
2023-08-18 05:15:55.666 [debug] RateLimit> Extension rate limit remaining: 138, PullRequestFiles
2023-08-18 05:15:55.955 [debug] RateLimit> GraphQL Rate limit remaining: 4736, PullRequestComments
2023-08-18 05:15:55.955 [debug] RateLimit> GraphQL Rate limit remaining: 4736, PullRequestComments
2023-08-18 05:15:56.046 [debug] RateLimit> GraphQL Rate limit remaining: 4737, PullRequestFiles
2023-08-18 05:15:56.048 [debug] RateLimit> Extension rate limit remaining: 140, GetPendingReviewId
2023-08-18 05:15:56.369 [debug] RateLimit> GraphQL Rate limit remaining: 4735, GetPendingReviewId
2023-08-18 05:16:31.516 [debug] ReviewCommentController> No commenting ranges: File does not match any of the files in the review.
2023-08-18 05:16:31.516 [debug] ReviewCommentController> Providing 0 commenting ranges for vscode.d.ts.
2023-08-18 05:17:22.559 [debug] GitHubRepository> Fetch metadata - enter
2023-08-18 05:17:22.559 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-08-18 05:17:22.560 [debug] GitHubRepository> Fetch metadata - enter
2023-08-18 05:17:22.560 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-08-18 05:17:57.233 [debug] GitHubRepository> Fetch metadata - enter
2023-08-18 05:17:57.233 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-08-18 05:17:57.233 [debug] GitHubRepository> Fetch metadata - enter
2023-08-18 05:17:57.233 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-08-18 05:18:04.210 [debug] GitHubRepository> Fetch metadata - enter
2023-08-18 05:18:04.210 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-08-18 05:18:04.211 [debug] GitHubRepository> Fetch metadata - enter
2023-08-18 05:18:04.211 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-08-18 05:20:57.135 [debug] GitHubRepository> Fetch pull request 190609 - enter
2023-08-18 05:20:57.135 [debug] RateLimit> Extension rate limit remaining: 140, PullRequest
2023-08-18 05:20:57.626 [debug] RateLimit> GraphQL Rate limit remaining: 4734, PullRequest
2023-08-18 05:20:57.627 [debug] GitHubRepository> Fetch pull request 190609 - done
2023-08-18 05:20:57.628 [debug] RateLimit> Extension rate limit remaining: 140, GetBranch
2023-08-18 05:20:57.933 [debug] RateLimit> GraphQL Rate limit remaining: 4733, GetBranch
2023-08-18 05:20:57.933 [debug] PullRequestModel> Fetch file changes, base, head and merge base of PR #190609 - enter
2023-08-18 05:20:57.933 [debug] IssueModel> Fetch viewers latest review commit
2023-08-18 05:20:57.933 [debug] RateLimit> Extension rate limit remaining: 140, LatestReviewCommit
2023-08-18 05:20:58.235 [debug] RateLimit> GraphQL Rate limit remaining: 4732, LatestReviewCommit
2023-08-18 05:20:58.518 [debug] RateLimit> Extension rate limit remaining: 140, PullRequestComments
2023-08-18 05:20:58.518 [debug] RateLimit> Extension rate limit remaining: 139, PullRequestComments
2023-08-18 05:20:58.518 [debug] RateLimit> Extension rate limit remaining: 138, PullRequestFiles
2023-08-18 05:20:58.795 [debug] RateLimit> GraphQL Rate limit remaining: 4730, PullRequestComments
2023-08-18 05:20:58.796 [debug] RateLimit> GraphQL Rate limit remaining: 4730, PullRequestComments
2023-08-18 05:20:58.799 [debug] RateLimit> GraphQL Rate limit remaining: 4731, PullRequestFiles
2023-08-18 05:20:58.802 [debug] RateLimit> Extension rate limit remaining: 140, GetPendingReviewId
2023-08-18 05:20:59.114 [debug] RateLimit> GraphQL Rate limit remaining: 4729, GetPendingReviewId

Git:

2023-08-18 05:15:53.541 [trace] Operation start: Config (blocking: false, readOnly: false; retry: false; showProgress: true)
2023-08-18 05:15:53.579 [info] > git config --local branch.tyriar/162950_4.github-pr-owner-number [39ms]
2023-08-18 05:15:53.623 [info] > git config --get commit.template [40ms]
2023-08-18 05:15:54.161 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) --ignore-case refs/heads/tyriar/162950_4 refs/remotes/tyriar/162950_4 [574ms]
2023-08-18 05:15:54.263 [info] > git status -z -uall [98ms]
2023-08-18 05:15:54.267 [trace] Operation end: Config (blocking: false, readOnly: false; retry: false; showProgress: true)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.664 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.737 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/api/browser/mainThreadTerminalService.ts [108ms]
2023-08-18 05:15:55.751 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/api/common/extHost.api.impl.ts [113ms]
2023-08-18 05:15:55.754 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/api/common/extHostTypes.ts [113ms]
2023-08-18 05:15:55.762 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFix.ts [117ms]
2023-08-18 05:15:55.768 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts [119ms]
2023-08-18 05:15:55.774 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vscode-dts/vscode.proposed.terminalQuickFixProvider.d.ts [110ms]
2023-08-18 05:15:55.778 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/contrib/terminalContrib/quickFix/browser/terminalQuickFixBuiltinActions.ts [125ms]
2023-08-18 05:15:55.782 [info] > git show --textconv 719a6a6cdfe132852ab26434e5e80fae16a44941:src/vs/workbench/contrib/terminalContrib/quickFix/test/browser/quickFixAddon.test.ts [125ms]
2023-08-18 05:15:55.855 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/api/browser/ [114ms]
2023-08-18 05:15:55.855 [info] fatal: not a tree object
2023-08-18 05:15:55.856 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.866 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/api/common/ [112ms]
2023-08-18 05:15:55.866 [info] fatal: not a tree object
2023-08-18 05:15:55.866 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.868 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/api/common/ [111ms]
2023-08-18 05:15:55.868 [info] fatal: not a tree object
2023-08-18 05:15:55.869 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.880 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vscode-dts/ [103ms]
2023-08-18 05:15:55.880 [info] fatal: not a tree object
2023-08-18 05:15:55.881 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.881 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/contrib/terminalContrib/quickFix/browser/ [99ms]
2023-08-18 05:15:55.881 [info] fatal: not a tree object
2023-08-18 05:15:55.881 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.881 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/contrib/terminalContrib/quickFix/browser/ [109ms]
2023-08-18 05:15:55.881 [info] fatal: not a tree object
2023-08-18 05:15:55.881 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.882 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/contrib/terminalContrib/quickFix/browser/ [114ms]
2023-08-18 05:15:55.882 [info] fatal: not a tree object
2023-08-18 05:15:55.882 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:15:55.889 [info] > git ls-tree -l 719a6a6cdfe132852ab26434e5e80fae16a44941 -- src/vs/workbench/contrib/terminalContrib/quickFix/test/browser/ [103ms]
2023-08-18 05:15:55.889 [info] fatal: not a tree object
2023-08-18 05:15:55.889 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:16:31.399 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2023-08-18 05:16:31.667 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2023-08-18 05:16:31.668 [trace] [svte] Repository for editor resource c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts already exists: c:\Github\microsoft\vscode
2023-08-18 05:16:31.791 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:16:31.801 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:16:31.906 [info] > git ls-files --stage -- C:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts [104ms]
2023-08-18 05:16:31.924 [trace] Operation start: CheckIgnore (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:16:31.933 [info] > git show --textconv :src/vscode-dts/vscode.d.ts [141ms]
2023-08-18 05:16:31.933 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:16:31.992 [info] > git check-ignore -v -z --stdin [67ms]
2023-08-18 05:16:31.992 [trace] Operation end: CheckIgnore (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:16:32.008 [info] > git cat-file -s db7d29f3b1b07f33a0869bc0e9c150d3525c7c8e [96ms]
2023-08-18 05:16:32.008 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:17:19.370 [debug] [wt] Change: c:\Github\microsoft\vscode\.vscode\shared.code-snippets
2023-08-18 05:17:20.377 [trace] Operation start: Status (blocking: false, readOnly: false; retry: false; showProgress: true)
2023-08-18 05:17:20.419 [info] > git config --get commit.template [36ms]
2023-08-18 05:17:20.988 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) --ignore-case refs/heads/tyriar/162950_4 refs/remotes/tyriar/162950_4 [600ms]
2023-08-18 05:17:21.067 [trace] Operation start: Log (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:21.089 [info] > git status -z -uall [93ms]
2023-08-18 05:17:21.091 [trace] Operation end: Status (blocking: false, readOnly: false; retry: false; showProgress: true)
2023-08-18 05:17:21.816 [info] > git log -n1 --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z -- c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts [748ms]
2023-08-18 05:17:21.817 [trace] Operation end: Log (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:22.559 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z 85de2f21c63608e8bbc5c2347fe927b00c8300bf [738ms]
2023-08-18 05:17:22.565 [trace] Operation start: GetBranches (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:22.565 [trace] Operation start: GetRefs (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:17:22.674 [info] > git for-each-ref --count=1 --sort -committerdate --format %(refname) %(objectname) %(*objectname) refs/remotes/origin/tyriar/162950_4 --contains 85de2f21c63608e8bbc5c2347fe927b00c8300bf [109ms]
2023-08-18 05:17:22.675 [trace] Operation end: GetRefs (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:17:22.675 [trace] Operation end: GetBranches (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:55.700 [trace] Operation start: Log (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:56.467 [info] > git log -n1 --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z -- c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts [768ms]
2023-08-18 05:17:56.468 [trace] Operation end: Log (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:57.232 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z 85de2f21c63608e8bbc5c2347fe927b00c8300bf [761ms]
2023-08-18 05:17:57.237 [trace] Operation start: GetBranches (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:17:57.237 [trace] Operation start: GetRefs (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:17:57.360 [info] > git for-each-ref --count=1 --sort -committerdate --format %(refname) %(objectname) %(*objectname) refs/remotes/origin/tyriar/162950_4 --contains 85de2f21c63608e8bbc5c2347fe927b00c8300bf [122ms]
2023-08-18 05:17:57.360 [trace] Operation end: GetRefs (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:17:57.360 [trace] Operation end: GetBranches (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:18:02.699 [trace] Operation start: Log (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:18:03.445 [info] > git log -n1 --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z -- c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts [747ms]
2023-08-18 05:18:03.446 [trace] Operation end: Log (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:18:04.210 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z 85de2f21c63608e8bbc5c2347fe927b00c8300bf [759ms]
2023-08-18 05:18:04.215 [trace] Operation start: GetBranches (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:18:04.216 [trace] Operation start: GetRefs (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:18:04.337 [info] > git for-each-ref --count=1 --sort -committerdate --format %(refname) %(objectname) %(*objectname) refs/remotes/origin/tyriar/162950_4 --contains 85de2f21c63608e8bbc5c2347fe927b00c8300bf [121ms]
2023-08-18 05:18:04.337 [trace] Operation end: GetRefs (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-08-18 05:18:04.337 [trace] Operation end: GetBranches (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-08-18 05:18:15.738 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2023-08-18 05:18:15.738 [trace] [svte] Repository for editor resource c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts already exists: c:\Github\microsoft\vscode
2023-08-18 05:18:18.468 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2023-08-18 05:18:18.468 [trace] [svte] Repository for editor resource c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts already exists: c:\Github\microsoft\vscode
2023-08-18 05:18:18.483 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2023-08-18 05:18:18.483 [trace] [svte] Repository for editor resource c:\Github\microsoft\vscode\src\vscode-dts\vscode.d.ts already exists: c:\Github\microsoft\vscode
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Aug 18, 2023
@Tyriar Tyriar added the papercut 馃└ A particularly annoying issue impacting someone on the team label Aug 18, 2023
@alexr00 alexr00 added this to the August 2023 milestone Aug 18, 2023
@alexr00 alexr00 mentioned this issue Aug 21, 2023
Merged
alexr00 added a commit that referenced this issue Aug 21, 2023
@alexr00
Add logging around copying permalinks
b64c009 
Part of #5185
alexr00 added a commit that referenced this issue Aug 21, 2023
@alexr00
Add logging around copying permalinks (#5189)
b47b2ea 
Part of #5185
@alexr00 alexr00 modified the milestones: August 2023, September 2023 Aug 23, 2023
@meganrogge
Copy link
Contributor

I see this frequently; I had thought it was a me problem 馃槄 .

@alexr00
Copy link
Member

alexr00 commented Aug 28, 2023

@meganrogge I added more logging. Can you set the default log level of GitHub Pull Request to "debug" and then share logs the next time you see this?

@alexr00 alexr00 modified the milestones: September 2023, On Deck Sep 13, 2023
@alexr00
Copy link
Member

alexr00 commented Dec 14, 2023

Closing, @Tyriar and @meganrogge if you see it please share logs!

@alexr00 alexr00 closed this as completed Dec 14, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Dec 14, 2023

This still happens constantly for me, looking at the logs it looks like the issue might be me expecting it to happen immediately but it's taking over 3 seconds:

2023-12-14 07:55:51.292 [debug] Permalink> getting file and position
2023-12-14 07:55:51.293 [debug] Permalink> got file and position: c:\Github\microsoft\vscode\src\vs\workbench\contrib\quickaccess\browser\commandsQuickAccess.ts 103:68
2023-12-14 07:55:52.649 [debug] RateLimit> GraphQL Rate limit remaining: 4905, GetMilestonesWithIssues
2023-12-14 07:55:52.649 [debug] GitHubRepository> Fetch all issues - done
2023-12-14 07:55:52.649 [debug] GitHubRepository> Fetch issues without milestone- enter
2023-12-14 07:55:52.650 [debug] RateLimit> Extension rate limit remaining: 140, IssuesWithoutMilestone
2023-12-14 07:55:54.021 [debug] Permalink> commit hash: cb0ff849b874492a8783aacbe2d54147e8d11c3e
2023-12-14 07:55:54.021 [debug] GitHubRepository> Fetch metadata - enter
2023-12-14 07:55:54.021 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-12-14 07:55:54.021 [debug] GitHubRepository> Fetch metadata - enter
2023-12-14 07:55:54.021 [debug] GitHubRepository> Fetch metadata microsoft/vscode - done
2023-12-14 07:55:54.130 [debug] Permalink> upstream: https://github.com/microsoft/vscode
2023-12-14 07:55:54.130 [debug] Permalink> permalink generated: https://github.com/microsoft/vscode/blob/cb0ff849b874492a8783aacbe2d54147e8d11c3e/src/vs/workbench/contrib/quickaccess/browser/commandsQuickAccess.ts#L104-L112
2023-12-14 07:55:54.130 [debug] Permalink> writing https://github.com/microsoft/vscode/blob/cb0ff849b874492a8783aacbe2d54147e8d11c3e/src/vs/workbench/contrib/quickaccess/browser/commandsQuickAccess.ts#L104-L112 to the clipboard
2023-12-14 07:55:56.296 [debug] RateLimit> GraphQL Rate limit remaining: 4902, IssuesWithoutMilestone
2023-12-14 07:55:56.297 [debug] GitHubRepository> Fetch issues without milestone - done

Can we make it near instant? I'm not sure why it takes so long to get the commit hash, the extension should already know what it is?

@Tyriar Tyriar reopened this Dec 14, 2023
@alexr00 alexr00 modified the milestones: On Deck, December / January 2024 Dec 18, 2023
@alexr00
Copy link
Member

alexr00 commented Dec 18, 2023

We are currently making 2 git calls to get the commit hash. I can reduce it to 1, but we still need the one to tell if the file is actually under source control. Let's see if that helps.

alexr00 added a commit that referenced this issue Dec 18, 2023
@alexr00
Speed up copy permalink
c62d66d 
Fixes #5185
@alexr00 alexr00 mentioned this issue Dec 18, 2023
Merged
alexr00 added a commit that referenced this issue Dec 18, 2023
@alexr00
Speed up copy permalink (#5562)
7ea95e4 
* Speed up copy permalink
Fixes #5185

* Fix test
@Tyriar
Copy link
Member Author

Tyriar commented Dec 18, 2023

@alexr00 could we do that eagerly in the background when the repo commit changes locally as that shouldn't happen often?

@alexr00
Copy link
Member

alexr00 commented Dec 18, 2023

@Tyriar it's per file, so we would have to eagerly make the call every time you change files.

@lramos15 lramos15 added the verified Verification succeeded label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug papercut 馃└ A particularly annoying issue impacting someone on the team verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speed up copy permalink microsoft/vscode-pull-request-github
4 participants
@Tyriar @lramos15 @meganrogge @alexr00