Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create-PR view: sparkle icon doesn't visually indicate that it has focus #5471

Closed
ulugbekna opened this issue Nov 15, 2023 · 4 comments · Fixed by #5473, #5522 or #5536
Closed

Create-PR view: sparkle icon doesn't visually indicate that it has focus #5471

ulugbekna opened this issue Nov 15, 2023 · 4 comments · Fixed by #5473, #5522 or #5536
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded

Comments

@ulugbekna
Copy link

Screen.Recording.2023-11-15.at.12.11.29.mov

GHPR v0.77.2023111509

Version: 1.85.0-insider
Commit: 54821ee1f14beca4866abd7de86175b4794b030d
Date: 2023-11-14T12:58:56.073Z
Electron: 25.9.4
ElectronBuildId: 25127168
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.1.0
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 15, 2023
@alexr00 alexr00 added this to the November 2023 milestone Nov 15, 2023
alexr00 added a commit that referenced this issue Nov 15, 2023
@alexr00
Create-PR view: sparkle icon doesn't visually indicate that it has focus
2d2b9c2 
Fixes #5471
@alexr00 alexr00 mentioned this issue Nov 15, 2023
Merged
alexr00 added a commit that referenced this issue Nov 15, 2023
@alexr00
Create-PR view: sparkle icon doesn't visually indicate that it has fo…
42c1f32 
…cus (#5473)

Fixes #5471
@ulugbekna
Copy link
Author

ulugbekna commented Nov 29, 2023 •
edited
Loading

@alexr00 A heads up: the focus is hardly visible & seems to have padding issues (the focus bg should be larger?). Would you like me to create another issue?

image

@alexr00 alexr00 added the verification-found Issue verification failed label Nov 29, 2023
@alexr00 alexr00 reopened this Nov 29, 2023
@alexr00
Copy link
Member

alexr00 commented Nov 29, 2023 •
edited
Loading

SCM is using the same hover background and the same color for the input box, so I will stay consistent with that. The size of the hover can be improved though.

alexr00 added a commit that referenced this issue Nov 29, 2023
@alexr00
Make hover background larger on sparkle
552f464 
Fixes #5471
@alexr00 alexr00 mentioned this issue Nov 29, 2023
Merged
alexr00 added a commit that referenced this issue Nov 29, 2023
@alexr00
Make hover background larger on sparkle (#5522)
cb4d882 
Fixes #5471
@ulugbekna
Copy link
Author

ulugbekna commented Nov 29, 2023 •
edited
Loading

SCM is using the same hover background

It's just tabing on the sparkle shows blue border

Screen.Recording.2023-11-29.at.17.13.23.mov

@alexr00 alexr00 reopened this Nov 29, 2023
@alexr00
Copy link
Member

alexr00 commented Dec 1, 2023

This border has proven to be difficult to replicate in a webview.

@alexr00 alexr00 modified the milestones: November 2023, December 2023 Dec 1, 2023
@behnamkhanioffical behnamkhanioffical mentioned this issue Dec 1, 2023
Closed
alexr00 added a commit that referenced this issue Dec 5, 2023
@alexr00
Focus border + hover highlight on sparkle action
ba1df72 
Fixes #5471
@alexr00 alexr00 mentioned this issue Dec 5, 2023
Merged
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
@alexr00 alexr00 added this to the December / January 2024 milestone Dec 11, 2023
alexr00 added a commit that referenced this issue Dec 12, 2023
@alexr00
Focus border + hover highlight on sparkle action (#5536)
2427f6c 
Fixes #5471
@bhavyaus bhavyaus added the verified Verification succeeded label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
No milestone
4 participants
@joaomoreno @ulugbekna @bhavyaus @alexr00