Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Visual Studio Code Web Extensions_ GitHub Pull request_ Create Pull request _Usability: At high contrast mode "Create with option" arrow button is not visible. #5480

Closed
tripathiakhil429 opened this issue Nov 17, 2023 · 3 comments · Fixed by #5493
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@tripathiakhil429
Copy link

tripathiakhil429 commented Nov 17, 2023

GitHub Tags: #A11yUsable;#A11yTCS;#BM_Visual Studio Code Web Extensions_Nov2023;#Visual Studio Code Web Extensions;#ChromiumEdge;#DesktopWeb;#A11ySev4;#Win11;#Highcontrast;

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Environment Details
Application Name: Visual Studio Code Web Extensions
URL: https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github
Operating System: Windows 11 Enterprise Insider Preview(23H2)
OS Build: 25997.1000
Edge version: 120.0.2210.7 (Official build) stable app, dev channel (64-bit)

Pre-Requisites

Settings<Accessibility<Contrast Themes<desert Mode.

Repro Steps

1.Hit the URL: https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github and login with git hub account.
2.Tab to "More Options" button present in the left navigation panel.
3.Tab to GitHub Pull request and press enter.
4.Tab to Create Pull request and press enter
5.Tab to "Create with Option" arrow button.
6.Observe at high contrast mode "Create with option" arrow button is not visible.

Actual

At high contrast (desert mode) "Create with option" arrow button is not visible.
Note: Issue is not repro'ing with high contrast aquatic mode

Expected

At high contrast (Desert mode) also "Create with option" arrow button should be visible clearly.

User Impact

Visually impaired users who uses high contrast for there better visibility will not be able to see the "issue causing control" clearly if the control is not visible in High contrast(Desert mode).

Attachment
5480 A11y_Visual Studio Code Web Extensions_ GitHub _Description _High Contrast At high contrast mode Create with option arrow button is not visible.webm

Aquatic mode: Issue does not repro
5480 A11y_Visual Studio Code Web Extensions_ GitHub Pull request_ Create Pull request _Usability

@tripathiakhil429 tripathiakhil429 changed the title A11y_Visual Studio Code Web Extensions_ GitHub _Description _High Contrast: At high contrast mode "Create with option" arrow button is not visible. A11y_Visual Studio Code Web Extensions_ GitHub Pull request_ Create Pull request _High Contrast: At high contrast mode "Create with option" arrow button is not visible. Nov 17, 2023
@alexr00 alexr00 self-assigned this Nov 20, 2023
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 20, 2023
@alexr00
Copy link
Member

alexr00 commented Nov 20, 2023

Occurs with "Desert" high contrast theme, not "Aquatic"

@alexr00 alexr00 added this to the November 2023 milestone Nov 20, 2023
alexr00 added a commit that referenced this issue Nov 20, 2023
@tripathiakhil429 tripathiakhil429 changed the title A11y_Visual Studio Code Web Extensions_ GitHub Pull request_ Create Pull request _High Contrast: At high contrast mode "Create with option" arrow button is not visible. A11y_Visual Studio Code Web Extensions_ GitHub Pull request_ Create Pull request _Usability: At high contrast mode "Create with option" arrow button is not visible. Nov 20, 2023
pull bot pushed a commit to binsee/vscode-pull-request-github that referenced this issue Nov 21, 2023
@tripathiakhil429
Copy link
Author

@alexr00 Verified the issue in given environment(https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github)
The issue is still repro in desert mode.
Edge Version:121.0.2220.3 (Official build) stable app, dev channel (64-bit)

@alexr00
Copy link
Member

alexr00 commented Nov 21, 2023

@tripathiakhil429 the fix was not available yet at that time. To retest:

  • Open the environment
  • Open the Extensions view
  • Look for GitHub Pull Requests and Issues
  • If it says a reload is required, reload
  • At this point, the fix will be available.

@rzhao271 rzhao271 added the verified Verification succeeded label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants