Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Semantic heading tag is missing in issue and PR webview comments #5524

Closed
jooyoungseo opened this issue Nov 30, 2023 · 4 comments · Fixed by #5608
Closed
Assignees
Labels
accessibility bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@jooyoungseo
Copy link

jooyoungseo commented Nov 30, 2023

Type: Bug

CC @meganrogge

If screen reader users open any GitHub issue or PR containing multiple comments in VSCode, SR users expect to jump between comments by using semantic heading. On gitHub webpage, each commentor name is denoted with h3 tag. However, currently, VSCode GH extension does not have the h3 tag for commentors name so it's hard to navigate between comments.

Extension version: 0.77.2023112911
VS Code version: Code - Insiders 1.85.0-insider (8762127fc97b8aaae5f3a0dd6a6d853d9a1b7574, 2023-11-29T17:38:23.440Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 15.71GB (5.82GB free)
Process Argv --crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9
Screen Reader yes
VM 0%
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
a9j8j154:30646983
showlangstatbar:30737417
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
pythonmpswarning:30901777
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30902439
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
aa_t_chat:30882232

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility labels Nov 30, 2023
@meganrogge meganrogge modified the milestones: December 2023, February 2024 Nov 30, 2023
@joaomoreno joaomoreno removed this from the February 2024 milestone Dec 11, 2023
@alexr00 alexr00 added this to the December / January 2024 milestone Dec 11, 2023
@alexr00
Copy link
Member

alexr00 commented Jan 11, 2024

This is cool. I didn't know screen readers did this.

@rzhao271
Copy link
Contributor

rzhao271 commented Jan 25, 2024

Adding verified for now, but in the comment-header-info component, it looks like the author name is denoted with a strong tag instead of an h3 tag. In other words, in-file comments (not description view comments) seem to have author names that aren't in h3 tags.

Should that be changed as well?

Devtools showing that in-file PR review comments have the author bolded with a strong tag inside of a div rather than the title section being inside an h3

@jooyoungseo
Copy link
Author

jooyoungseo commented Jan 26, 2024 via email

@alexr00
Copy link
Member

alexr00 commented Jan 26, 2024

For comment threads in the editor we have commands with keybindings: editor.action.nextCommentThreadAction and editor.action.previousCommentThreadAction (alt+f9 and shift+alt+f9 respectively). Are semantic tags also supposed to work in the editor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants