Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.79 (probably 0.78 too?) collapses an open PR review tree on refresh #5556

Closed
janakjjp opened this issue Dec 14, 2023 · 1 comment · Fixed by #5634
Closed

0.79 (probably 0.78 too?) collapses an open PR review tree on refresh #5556

janakjjp opened this issue Dec 14, 2023 · 1 comment · Fixed by #5634
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@janakjjp
Copy link

  • Extension version: 0.79 prerelease
  • VSCode Version: 1.85.0
  • OS: macOS Sonoma 14.1.2
  • Repository Clone Configuration (single repository/fork of an upstream repository): N/A (PR review)
  • Github Product (Github.com/Github Enterprise version x.x.x): GHE 3.7.0

Steps to Reproduce:

  1. Go to the GH Pull Requests & Issues pane.
  2. Expand a pull request to review. (Optionally, choose a file.)
  3. Hit the refresh button next to the "PULL REQUESTS" header. (Or, just wait until an auto-refresh triggers.)

Expected behavior:

Your current pull request stays open so you can continue reviewing it. This was the behavior in 0.76.

Actual behavior:

The tree closes and refreshes from scratch. This means, if you're mid-review, you must re-expand the PR and find your spot. This is exacerbated by the auto-refresh. If I'm reviewing a PR with many files, I have to keep on expanding and scrolling to my current review spot.
@alexr00 alexr00 self-assigned this Jan 19, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jan 19, 2024
@alexr00 alexr00 added this to the December / January 2024 milestone Jan 19, 2024
alexr00 added a commit that referenced this issue Jan 19, 2024
@alexr00
Fix PRs in PRs tree collapses on refresh
48fdb6d 
Fixes #5556
@alexr00 alexr00 mentioned this issue Jan 19, 2024
Merged
@alexr00
Copy link
Member

alexr00 commented Jan 19, 2024

Thanks for reporting this!

alexr00 added a commit that referenced this issue Jan 19, 2024
@alexr00
Fix PRs in PRs tree collapses on refresh (#5634)
aaa4061 
* Fix PRs in PRs tree collapses on refresh
Fixes #5556

* Fix test
@eleanorjboyd eleanorjboyd added verification-steps-needed Steps to verify are needed for verification verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PRs in PRs tree collapses on refresh microsoft/vscode-pull-request-github
3 participants
@eleanorjboyd @alexr00 @janakjjp