Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with merge commitbutton does not go away despite merging #5661

Closed
Tracked by #5778
bhavyaus opened this issue Jan 23, 2024 · 3 comments · Fixed by #5702
Closed
Tracked by #5778

Update with merge commitbutton does not go away despite merging #5661

bhavyaus opened this issue Jan 23, 2024 · 3 comments · Fixed by #5702
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bhavyaus
Copy link

Testing #5649

I used the button to merge in newer changes from the base. After which I expected the button to disappear but the button remains.

Screen.Recording.2024-01-23.at.11.26.39.mov
@alexr00
Copy link
Member

alexr00 commented Jan 24, 2024

@bhavyaus did you also push you merge?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Jan 24, 2024
@bhavyaus
Copy link
Author

@bhavyaus did you also push you merge?

No. I did not take any other actions besides click on the "Update with merge commit". Would that not also push my merge?

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jan 31, 2024
@alexr00 alexr00 added this to the February 2024 milestone Jan 31, 2024
@alexr00
Copy link
Member

alexr00 commented Jan 31, 2024

You're correct, it should push your merge. I was confusing this with the "resolve conflicts" button. I think the only issue is that it's a little slow to update. I'll add button disablement and make it a bit faster to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants