Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle renamed files #5767

Closed
jsoref opened this issue Feb 18, 2024 · 4 comments · Fixed by #5831 or #5890
Closed

Handle renamed files #5767

jsoref opened this issue Feb 18, 2024 · 4 comments · Fixed by #5831 or #5890
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Milestone

Comments

@jsoref
Copy link

jsoref commented Feb 18, 2024

Improve handling for renamed files

Currently when I click on a png file that's listed as R (which is apparently a Renamed file), I get:
image
image
image
image

Ideally:

  • I should be able to view the file locally and have a thing that tells me its renamed at the top/bottom of the view
  • I should be able to add comments on the file change (as I can in the GitHub web ui)

In the interim, it'd be nice if the floating message at the bottom said "because it's a rename" -- so it's clear it's because of the R and not, e.g. because it's a .png.

@alexr00
Copy link
Member

alexr00 commented Mar 11, 2024

I'm not able to repro this with a rename. Do you have a public PR I could look at that shows this issue?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Mar 11, 2024
@jsoref
Copy link
Author

jsoref commented Mar 11, 2024

The repository in question is/was https://github.com/check-spelling-sandbox/GraphScope/
check-spelling-sandbox/GraphScope@1f8d832 is a commit with the change.

@alexr00
Copy link
Member

alexr00 commented Mar 11, 2024

I can repro, thanks!

@alexr00 alexr00 self-assigned this Mar 13, 2024
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 13, 2024
@alexr00 alexr00 added this to the March 2024 milestone Mar 13, 2024
alexr00 added a commit that referenced this issue Mar 13, 2024
@roblourens roblourens added the verified Verification succeeded label Mar 26, 2024
@roblourens
Copy link
Member

This is working for a text file, but not an image

image

In this PR that just does a basic rename of two files

https://github.com/roblourens/testrepo/pull/13

@roblourens roblourens reopened this Mar 26, 2024
@roblourens roblourens added verification-found Issue verification failed and removed verified Verification succeeded labels Mar 26, 2024
@alexr00 alexr00 modified the milestones: March 2024, April 2024 Mar 27, 2024
alexr00 added a commit that referenced this issue Apr 4, 2024
alexr00 added a commit that referenced this issue Apr 4, 2024
@bhavyaus bhavyaus added verified Verification succeeded verification-found Issue verification failed and removed verification-found Issue verification failed labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Projects
None yet
4 participants