Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR order does not match multi-root order anymore #5789

Closed
bpasero opened this issue Feb 28, 2024 · 5 comments · Fixed by #5795 or #5964
Closed

PR order does not match multi-root order anymore #5789

bpasero opened this issue Feb 28, 2024 · 5 comments · Fixed by #5795 or #5964
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2024

Comments

@bpasero
Copy link
Member

bpasero commented Feb 28, 2024

I see that a PR from vscode-docs appears above the PR for vscode:

image

Even though my MR order is this:

image
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2024
@alexr00 alexr00 added this to the March 2024 milestone Feb 28, 2024
alexr00 added a commit that referenced this issue Feb 28, 2024
@alexr00
PR order does not match multi-root order anymore
253b84b 
Fixes #5789
@alexr00 alexr00 mentioned this issue Feb 28, 2024
Merged
@alexr00
Copy link
Member

alexr00 commented Feb 28, 2024

Looks like this never intentionally matched the multiroot order.

alexr00 added a commit that referenced this issue Feb 28, 2024
@alexr00
PR order does not match multi-root order anymore (#5795)
5fc7edb 
Fixes #5789
@bpasero
Copy link
Member Author

bpasero commented Feb 28, 2024

Interesting, I really thought I had filed this exact same issue some time ago.

@alexr00
Copy link
Member

alexr00 commented Mar 4, 2024

I know I fixed an issue at some point where the repos were in the wrong order in the "Pull Requests" view. You probably filed that one!

@bpasero bpasero added the verified Verification succeeded label Mar 25, 2024
@bpasero
Copy link
Member Author

bpasero commented Mar 25, 2024

I think the order was still wrong when I created a PR first from a workspace folder N | N > 1 and then with N = 0 but it settled after a window reload. Maybe sorting is not applied when creating a PR?

@bpasero bpasero reopened this Apr 23, 2024
@bpasero bpasero removed this from the March 2024 milestone Apr 23, 2024
@bpasero bpasero added verification-found Issue verification failed and removed verified Verification succeeded labels Apr 23, 2024
@bpasero
Copy link
Member Author

bpasero commented Apr 23, 2024 •
edited

The order is not correct for me in insiders:

Screenshot 2024-04-23 at 06 47 45

Even when I reload the window.

@alexr00 alexr00 added this to the April 2024 milestone Apr 23, 2024
alexr00 added a commit that referenced this issue Apr 25, 2024
@alexr00
Fix incorrect checks for descendants
812de14 
Fixes #5789
@alexr00 alexr00 mentioned this issue Apr 25, 2024
Merged
alexr00 added a commit that referenced this issue Apr 25, 2024
@alexr00
Fix incorrect checks for descendants (#5964)
82778bd 
Fixes #5789
@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2024
3 participants
@bpasero @rzhao271 @alexr00