Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The icon for un-resolve is too close to undo #5868

Closed
dbaeumer opened this issue Mar 25, 2024 · 6 comments · Fixed by #5899
Closed

The icon for un-resolve is too close to undo #5868

dbaeumer opened this issue Mar 25, 2024 · 6 comments · Fixed by #5899
Assignees
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #5862

That is very minor. But the icon for un-resolve reminds me of undo and it is actually not an undo IMO. The action is more a re-open conversation.

I do prefer re-open over un-resolve but it looks like GitHub is using the same name. So feel free to close if this doesn't justify to make us different from GitHub

@alexr00
Copy link
Member

alexr00 commented Mar 26, 2024

It currently uses the discard icon, but we can probably do better. Maybe the debug-restart icon? @hbons in case you have some suggestions!

@alexr00 alexr00 added this to the April 2024 milestone Mar 26, 2024
@alexr00 alexr00 added the polish label Mar 26, 2024
@hbons
Copy link
Member

hbons commented Mar 26, 2024

@dbaeumer can you add a screenshot for context? Maybe we should stick to a label here if we can't find the right icon.

@alexr00
Copy link
Member

alexr00 commented Mar 26, 2024

@hbons labels for inline actions are technically supported, but I think we don't use them in any of our extensions. Screenshot:

image

@hbons
Copy link
Member

hbons commented Mar 27, 2024

@alexr00 thanks! on GitHub reopening issues and rerequesting reviews uses a refresh like icon. so refresh could work?
image

@hbons
Copy link
Member

hbons commented Mar 27, 2024

or sync:
image

@alexr00
Copy link
Member

alexr00 commented Mar 27, 2024

sync seems good, I'll switch to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants