Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git setting to fetch before checkout in checkoutExistingPullRequestBranch #4759

Merged
merged 10 commits into from May 12, 2023
Merged

Use git setting to fetch before checkout in checkoutExistingPullRequestBranch #4759

merged 10 commits into from May 12, 2023

Conversation

unknovvn
Copy link
Contributor

#4346 Add a setting to prevent fetch on checkout

@unknovvn
Copy link
Contributor Author

@microsoft-github-policy-service agree

@unknovvn
Copy link
Contributor Author

unknovvn commented May 6, 2023 •
edited

@alexr00 how should I prompt someone for a review? :)

@alexr00
Copy link
Member

alexr00 commented May 9, 2023

@unknovvn once you address #4759 (comment) I will take a look.

alexr00
alexr00 requested changes May 10, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Could you please revert all the changes that are exclusively formatting changes?

@unknovvn
Copy link
Contributor Author

@alexr00 I have reverted formatting changes as requested

@unknovvn unknovvn requested a review from alexr00 May 10, 2023 10:59
alexr00
alexr00 requested changes May 10, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for revertting the formatting changes! It made it much faster for me to review.

src/github/pullRequestGitHelper.ts Outdated Show resolved Hide resolved
@unknovvn unknovvn requested a review from alexr00 May 11, 2023 19:52
alexr00
alexr00 approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexr00 alexr00 added this to the May 2023 milestone May 12, 2023
@alexr00 alexr00 enabled auto-merge (squash) May 12, 2023 09:37
@alexr00 alexr00 merged commit 117e817 into microsoft:main May 12, 2023
3 checks passed
@unknovvn unknovvn mentioned this pull request May 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulugbekna ulugbekna ulugbekna approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unknovvn @alexr00 @ulugbekna