Show pull request id in title #540
Conversation
|
@RMacfarlane what's the process for getting PRs looked at? Also I didn't get a CLA bot on this and I think I need to deal with that. Thanks! |
|
Hmm, I'm not sure why the bot didn't kick in. I'll look into it. There's not really a formalized process for reviews, right now I'm trying to get to them within a day of their creation, but am also balancing other work 😃 |
Ok - thanks for replying so quickly and for all your hard work! I'm new to the open source stuff but Hacktoberfest has really inspired me to try to find tools I use and help improve them :) |
|
Awesome! I looked more into the CLA bot, documentation on it says it doesn't trigger on small changes. There's a checkmark next to your commit saying that all CLA requirement are met, so we're good there. This does clearly fix the problem in #537 but it also takes up more horizontal space, which I'm not sure we want. @misolori @rebornix what do you think, is there another way we could show this info? We could show it in the tooltip, but that's not very useful at a glance. I wish the VSCode tree API allowed setting a description or providing a custom render function for tree items. |
|
Thanks for taking a look at this! I do think that adding it to the front of the string adds visual noise when it's intended to be secondary info, so I think I prefer it being added to the end of the string instead:
Ideally if we could add decorations on the line, similar to the git/scm decorations, we could add a different color to make them stand out less, but I'm not sure if that's possible. |
|
I've updated this PR. |
|
Thanks! I'd also double-check that it gets added to the tooltip, doesn't look like it was added there as well. |
|
I just pushed a change to add the tooltip. |
Addresses #537