This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Working Backend and Frontend for CLUE Screen #266
Merged
andreamah
merged 75 commits into
dev
from
users/t-anmah/clue-frontend-backend-integration
Mar 26, 2020
Merged
Working Backend and Frontend for CLUE Screen #266
andreamah
merged 75 commits into
dev
from
users/t-anmah/clue-frontend-backend-integration
Mar 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into users/t-xunguy/clue-communication
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
reviewed
Mar 25, 2020
vandyliu
suggested changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't believe I just read all of that but it was worth it! Excellent job!!!!!!!!!!!!!!!!!!!!!!! 👯 💃 👯♂ 🕺
…ps://github.com/microsoft/vscode-python-devicesimulator into users/t-anmah/clue-frontend-backend-integration
vandyliu
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!! :D
Excited to merge it.
isadorasophia
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool! Really nice job on the documentation too 😁
…ps://github.com/microsoft/vscode-python-devicesimulator into users/t-anmah/clue-frontend-backend-integration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This initial CLUE PR allows for the following:
https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font
NOTE 1: adafruit_display_text is present within a tar.gz of the latest release on GitHub, since they seemed to have manually disabled deployment to PyPI. Coincidentally, adafruit_display_text also required a few fixes for off-by-one errors, so that it incorporated in the tar.gz
NOTE 2: adafruit_clue is not downloaded via PyPI, but is a local revised version that is pre-downloaded.
Neopixel (excluding neopixel_write), adafruit_fancyled, adafruit_bitmap_font, and adafruit_display_shapes are all downloaded directly from PyPI upon setup. They are installed as dependencies.
Directory structure for new folders:
Frontend-backend communication:
Frontend Info:
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Here are some tests that I ran & verified that it looks the same on the device:
and
NOTE: it is known that it bugs out if you switch between clue_data.pixel.fill() and clue_data.show(). This is because the pixel is not implemented on the frontend.
https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes/blob/master/examples/display_shapes_simpletest.py
Checklist:
npm run format
and passes the checks innpm run check