Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builds are failing #17666

Closed
kimadeline opened this issue Oct 8, 2021 · 3 comments · Fixed by #17757 or #18406
Closed

Builds are failing #17666

kimadeline opened this issue Oct 8, 2021 · 3 comments · Fixed by #17757 or #18406
Assignees
@karrtikr
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@kimadeline
Copy link

kimadeline commented Oct 8, 2021 •
edited

https://github.com/microsoft/vscode-python/actions/workflows/build.yml?query=branch%3Amain

image

Started happening when VS Code 1.61 was released. Looks like there are terminal activation issues, and one TensorBoard issue.

The TB issue seems to go away if I add torch-tb-profiler ; python_version > '2.7' to the test reqs (#17664), but I have no idea why it's suddenly needed, or why some terminal activation tests are failing.
@kimadeline kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-internal Label for non-user facing issues labels Oct 8, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 8, 2021
@kimadeline kimadeline removed the triage-needed Needs assignment to the proper sub-team label Oct 8, 2021
@kimadeline kimadeline mentioned this issue Oct 8, 2021
Merged
@karthiknadig karthiknadig self-assigned this Oct 12, 2021
@karthiknadig
Copy link
Member

After investigating by me and @karrtikr we found the issue to be with inspect API from VS Code for the settings. with the latest version of VS Code this API does not retrieve the right value as expected.

@karrtikr
Copy link

Opened VSCode issue: microsoft/vscode#135121

@karrtikr karrtikr mentioned this issue Oct 14, 2021
Closed
karthiknadig added a commit to karthiknadig/vscode-python that referenced this issue Oct 15, 2021
@karthiknadig
Skip tests due to microsoft#17666
0e2bf4f
karthiknadig added a commit that referenced this issue Oct 15, 2021
@karthiknadig
Skip tests due to #17666 (#17757)
c897479
@karthiknadig karthiknadig linked a pull request Oct 15, 2021 that will close this issue
Skip tests due to #17666 #17757
Merged
@karthiknadig
Copy link
Member

Revert this commit c897479 after microsoft/vscode#135121 is fixed

@karthiknadig karthiknadig removed their assignment Oct 28, 2021
@kieferrm kieferrm mentioned this issue Nov 7, 2021
Closed
32 tasks
@luabud luabud added important Issue identified as high-priority and removed P0 labels Dec 8, 2021
@kieferrm kieferrm mentioned this issue Dec 21, 2021
Closed
23 tasks
@karrtikr karrtikr self-assigned this Feb 1, 2022
@karrtikr karrtikr mentioned this issue Feb 1, 2022
Merged
@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
28 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
4 participants
@karthiknadig @karrtikr @luabud @kimadeline