Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The placeholder for Python env creation is incorrect #20899

Closed
DonJayamanne opened this issue Mar 22, 2023 · 3 comments
Closed

The placeholder for Python env creation is incorrect #20899

DonJayamanne opened this issue Mar 22, 2023 · 3 comments
Assignees
@luabud
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
March 2023

Comments

@DonJayamanne
Copy link

The placeholder should read Select a Python Env/Version instead of just Select a Python
Screenshot from here #20896

image
@DonJayamanne DonJayamanne added the feature-request Request for new features or functionality label Mar 22, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 22, 2023
@karthiknadig karthiknadig added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on and removed feature-request Request for new features or functionality labels Mar 23, 2023
@karthiknadig karthiknadig self-assigned this Mar 23, 2023
@karthiknadig karthiknadig added area-environments Features relating to handling interpreter environments and removed triage-needed Needs assignment to the proper sub-team labels Mar 23, 2023
@karthiknadig
Copy link
Member

@luabud for input. This was based on discussion here: #19891

@DonJayamanne for venv we explicitly don't show any envs, only actual python installs. So it might be misleading if we say env, as users might expect to see all python environments in the selector.

@DonJayamanne
Copy link
Author

What I’m saying is ‘Select a python’ alone doesn’t make sense

expect to see all python environments in the

you have said ‘all python environment’ , you didn’t say just ‘expect to see all python in the selector’
What I’m getting at is, adding something (context) to python makes more sense

This was referenced Mar 23, 2023
Closed
Merged
karthiknadig pushed a commit that referenced this issue Mar 23, 2023
@luabud
Adjust a few strings that mention Python (#20900)
be55c97 
For #20899 (+ a few
other strings I thought could use some tweaking too)
@karthiknadig karthiknadig removed their assignment Mar 23, 2023
@karthiknadig
Copy link
Member

Thanks @luabud for the fix via #20900

@karrtikr karrtikr added this to the March 2023 milestone Mar 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
@eleanorjboyd eleanorjboyd removed the needs PR Ready to be worked on label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
March 2023
Development

No branches or pull requests
5 participants
@DonJayamanne @karthiknadig @karrtikr @eleanorjboyd @luabud