Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong use of quick pick title and placeholder #19891

Closed
jrieken opened this issue Sep 27, 2022 · 8 comments · Fixed by #19925 or #20896
Closed

Wrong use of quick pick title and placeholder #19891

jrieken opened this issue Sep 27, 2022 · 8 comments · Fixed by #19925 or #20896
Assignees
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Sep 27, 2022

Testing #19883

  • create an env
  • the title part should provide orientation in a multi step quick pick
  • the placeholder part should tell what to do, like "Select Interpreter"
  • the currently selected env should be rendered with the env itself

Screenshot 2022-09-27 at 16 51 01

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 27, 2022
@jrieken
Copy link
Member Author

jrieken commented Sep 27, 2022

/cc @daviddossett for quick quick UX guidelines

@daviddossett
Copy link

daviddossett commented Sep 27, 2022

the title part should provide orientation in a multi step quick pick

Generally I agree unless for some reason the placeholder can't be used to describe the purpose. Here's an example following the pattern typically used:

CleanShot 2022-09-27 at 09 34 07@2x

I'll address this in more detail as part of microsoft/vscode#158895

@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug area-environments Features relating to handling interpreter environments labels Sep 27, 2022
@karthiknadig
Copy link
Member

@karrtikr The internal API for select environments needs a way to set the title.

@karrtikr karrtikr added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Sep 27, 2022
@karrtikr karrtikr added this to the September 2022 milestone Sep 27, 2022
@karrtikr karrtikr assigned karthiknadig and unassigned karrtikr Sep 27, 2022
@karrtikr
Copy link

karrtikr commented Sep 27, 2022

@karthiknadig Just exposed the API, reassigning.

@karthiknadig
Copy link
Member

karthiknadig commented Sep 27, 2022

@daviddossett @jrieken In this case do you recommend just updating the placeholder? or do you suggest we have a title like Create Environment and the placeholder say something like Select a python to create the virtual environment?

@daviddossett
Copy link

I think you can actually omit the title bar altogether and update the placeholder to be something like your example above (Select a python to create the virtual environment).

@karthiknadig
Copy link
Member

Looks like this got accidentally closed.

@karthiknadig
Copy link
Member

image

@karthiknadig karthiknadig added the verified Verification succeeded label Apr 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on verified Verification succeeded
Projects
None yet
6 participants