-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong use of quick pick title and placeholder #19891
Comments
/cc @daviddossett for quick quick UX guidelines |
Generally I agree unless for some reason the placeholder can't be used to describe the purpose. Here's an example following the pattern typically used: I'll address this in more detail as part of microsoft/vscode#158895 |
@karrtikr The internal API for select environments needs a way to set the title. |
@karthiknadig Just exposed the API, reassigning. |
@daviddossett @jrieken In this case do you recommend just updating the placeholder? or do you suggest we have a title like |
I think you can actually omit the title bar altogether and update the placeholder to be something like your example above ( |
Closes microsoft#19889 Closes microsoft#19890 Closes microsoft#19891 Closes microsoft#19894 Closes microsoft#19897 Closes microsoft#19852 Closes microsoft#19851 Closes microsoft#19838 Closes microsoft#19916 Closes microsoft#19917
Looks like this got accidentally closed. |
Testing #19883
The text was updated successfully, but these errors were encountered: