Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of options in "Create Environment" flow when .venv exists in the workspace #22038

Closed
luabud opened this issue Sep 20, 2023 · 5 comments · Fixed by #22055
Closed
Labels
feature-request Request for new features or functionality good first issue verification-needed Verification of issue is requested verified Verification succeeded

Comments

@luabud
Copy link
Member

luabud commented Sep 20, 2023

When there is already a virtual environment called .venv in the workspace and you run the "Python: Create Environment" command in VS Code & select "Venv", we show an option to delete the environment or use the existing one:
image

@cwebster-99 received some good feedback in user studies with a suggestion to change the order so "Use" shows before "Delete", as it's more likely folks will want to select the existing one than recreate it.

@luabud luabud added the feature-request Request for new features or functionality label Sep 20, 2023
@luabud
Copy link
Member Author

luabud commented Sep 20, 2023

We are reserving this issue for Grace Hopper's Open Source Day, which will take place on September 22nd, 2023. If you're part of the event and would like to submit a contribution to this issue, please let us know, and we'll be happy to assign it to you.

For other community members who are not participating in the event, we appreciate your interest in contributing! We kindly request that you wait until after September 22nd to work on this issue. If no one from the event has been assigned to it by then, we'll gladly assign it to you. Thank you for your understanding and support!

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 20, 2023
@luabud luabud added good first issue needs PR Ready to be worked on ghc-osd and removed triage-needed Needs assignment to the proper sub-team labels Sep 20, 2023
@luabud luabud changed the title Change order of options in create environment command when there already exists a .venv in the workspace Change order of options in "Create Environment" flow when a .venv already exists in the workspace Sep 20, 2023
@luabud luabud changed the title Change order of options in "Create Environment" flow when a .venv already exists in the workspace Change order of options in "Create Environment" flow when a .venv exists in the workspace Sep 20, 2023
@luabud luabud changed the title Change order of options in "Create Environment" flow when a .venv exists in the workspace Change order of options in "Create Environment" flow when .venv exists in the workspace Sep 20, 2023
@annaburlyaeva
Copy link

Hi, I'm participating in GHC Open Source Day and would like to work on this issue. Could you please assign it to me?

@luabud
Copy link
Member Author

luabud commented Sep 22, 2023

@annaburlyaeva done!

@annaburlyaeva
Copy link

Opened a pr #22055

@karrtikr
Copy link

@annaburlyaeva Fix should be out in the pre-release version of the extension in a day, use the following to try it out:

image

@karrtikr karrtikr added the verification-needed Verification of issue is requested label Sep 22, 2023
@Tyriar Tyriar added the verified Verification succeeded label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality good first issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants