Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed order of options in Create Environment flow when .venv exists #22055

Merged
merged 1 commit into from Sep 22, 2023
Merged

Changed order of options in Create Environment flow when .venv exists #22055

merged 1 commit into from Sep 22, 2023

Conversation

annaburlyaeva
Copy link

@annaburlyaeva annaburlyaeva commented Sep 22, 2023 •
edited by eleanorjboyd

closes #22038

@annaburlyaeva annaburlyaeva mentioned this pull request Sep 22, 2023
Closed
@eleanorjboyd eleanorjboyd added feature-request Request for new features or functionality skip tests Updates to tests unnecessary labels Sep 22, 2023
eleanorjboyd
eleanorjboyd approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@eleanorjboyd eleanorjboyd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for contributing! 🎉

I checkout this branch and tested the change myself and can confirm it looks good!

@karrtikr karrtikr merged commit 4ed3fa0 into microsoft:main Sep 22, 2023
29 of 31 checks passed
@luabud luabud added the ghc-osd label Sep 25, 2023
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Oct 2, 2023
@annaburlyaeva @eleanorjboyd
Changed order of options in Create Environment flow when .venv exists… (
f4e803d 
microsoft#22055)

closes microsoft#22038
@karthiknadig karthiknadig changed the title Changed order of options in Create Environment flow when .venv exists… Changed order of options in Create Environment flow when .venv exists Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees
No one assigned
Labels
feature-request Request for new features or functionality skip tests Updates to tests unnecessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change order of options in "Create Environment" flow when .venv exists in the workspace
4 participants
@annaburlyaeva @karrtikr @eleanorjboyd @luabud