Support Notebook Renderers with VS Code Notebooks (disabled) #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
IanMatthewHuff,
rchiodo,
DavidKutu,
greazer and
joyceerhl
rchiodo
reviewed
May 26, 2020
DonJayamanne
commented
May 26, 2020
DonJayamanne
commented
May 26, 2020
DonJayamanne
commented
May 26, 2020
DavidKutu
approved these changes
May 27, 2020
IanMatthewHuff
approved these changes
May 27, 2020
DonJayamanne
commented
May 27, 2020
| @@ -344,7 +356,8 @@ | |||
| "XCI_PYTHON_PATH": "<Python Path>" | |||
| }, | |||
| "outFiles": [ | |||
| "${workspaceFolder}/out/**/*.js" | |||
| "${workspaceFolder}/out/**/*.js", | |||
| "!${workspaceFolder}/**/node_modules**/*" | |||
There was a problem hiding this comment.
New changes due to new debugger in VS Code (we'll need this to ensure we ignore node_modules in the out folder). Else debugger is very slow to load, causing extension to take 5-8 minutes to activate.
DonJayamanne
commented
May 27, 2020
| interactiveWindow: ['babel-polyfill', `./src/datascience-ui/history-react/index.tsx`] | ||
| }; | ||
| function getEntry(bundle) { | ||
| switch (bundle) { |
There was a problem hiding this comment.
Switched to named bundles instead of a boolean.
DonJayamanne
commented
May 27, 2020
| @@ -298,7 +320,13 @@ function buildConfiguration(isNotebook) { | |||
| ] | |||
| } | |||
| }; | |||
|
|
|||
| if (bundle === 'renderers') { | |||
| delete config.optimization; | |||
There was a problem hiding this comment.
No optimization for renderer scripts, they don't work at all.
Will be resolved when VS Code adds support for loading split bundles.
DonJayamanne
added a commit
that referenced
this pull request
May 28, 2020
For #11999 When running unit tests we don't need to compile the webviews (no need to compile react, etc). Total time to compile code down from 6 minutes to 1 minute (i.e. 5 minutes faster CI to know whether tests passed/failed) Note the drop in compile times from ~7minutes to ~50s. (basically 6 minutes faster)
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10496
Unfortunately some stuff isn't working properly, however I'd like to get this reviewed. The fixes should be simple.