Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diag messages for magics #17057

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Aug 20, 2021

@rchiodo rchiodo added no-changelog No news entry required skip tests Updates to tests unnecessary labels Aug 20, 2021
@rchiodo rchiodo requested a review from a team August 20, 2021 21:10
@rchiodo rchiodo removed the no-changelog No news entry required label Aug 20, 2021
@deepbIue
Copy link

It appears that the implementation does not handle magic commands that are indented.
Example:

def a():
    pass

def b():
    #!%timeit a  # this does not work
    %timeit a  # this works but raises a syntax error

b()
#!%timeit a  # this works and does not raise a syntax error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inside of a notebook, magic cells should not cause an error in pylance
3 participants