Allow to specify title and placeholder in API for interpreter quickpick #19896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
added
no-changelog
karthiknadig
approved these changes
Sep 27, 2022
| @@ -47,7 +47,7 @@ export interface IQuickPickParameters<T extends QuickPickItem, E = any> { | |||
| canGoBack?: boolean; | |||
| items: T[]; | |||
| activeItem?: T | Promise<T>; | |||
| placeholder: string; | |||
| placeholder: string | undefined; | |||
There was a problem hiding this comment.
For Tech debt, we can probably get rid of multistepinput.ts
There was a problem hiding this comment.
Rid of in favor of what 🤔 we're still using it in many places. But yeah it could use some cleanup.
There was a problem hiding this comment.
Replacing the DI with calling raw vscode APIs. I can see the use for a wrapper function, but it is a state less class.
There was a problem hiding this comment.
This has internal states though, maybe they'll need to be passed in.
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #19891